Only load & validate type files in manager or when validate_schemas set #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s set Validation of type files takes a substantial amount of time whil should not be repeated in every module This commit also includes logging of the times it took to load a type yaml and validate it, as well as the total time module initialization and the complete startup process takes Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Cornelius Claussen <cc@pionix.de>
corneliusclaussen
approved these changes
Oct 12, 2023
hikinggrass
added a commit
to SirVer/everest-framework
that referenced
this pull request
Oct 16, 2023
…et (EVerest#106) * Only load & validate type files in manager or when validate_schemas is set Validation of type files takes a substantial amount of time which should not be repeated in every module This commit also includes logging of the times it took to load a type yaml and validate it, as well as the total time module initialization and the complete startup process takes --------- Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de> Signed-off-by: Cornelius Claussen <cc@pionix.de> Co-authored-by: Cornelius Claussen <cc@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation of type files takes a substantial amount of time whil should not be repeated in every module
This commit also includes logging of the times it took to load a type yaml and validate it, as well as the total time module initialization and the complete startup process takes