-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change REST API JSON Schemas to NIST GitHub References #32
Comments
Migrated from Jira |
I actually started a discussion at NIST OSCAL's repo on this as I was trying to figure out what was going on. |
Thanks @flickerfly, just added another comment there. |
Adding comments from a duplicate issue #48:
and
|
To provide an update on this, as of today, neither the OSCAL schemas have been updated nor has Swagger editor gotten support for OpenAPI v3.1. We will have to continue to point to our fork for now. It does look like the Metaschema change has been added to the 0.9.0 milestone which is their "current" milestone. |
@mpemy did you experience this. |
Made good progress on the collection of issues. This one will be addressed in sprint 68. |
Got some new insights from @brian-comply0, will address the remaining issue in sprint 69. |
A few versions back, NIST moved away from publishing the JSON schemas in the repo and only making them available as download assets. Unfortunately this prevents us from linking to those files "in place" from the OpenAPI file. The OpenAPI file needs to link to the schema files in a reliable and publicly accessible location. As a result, we moved clean copies of the NIST OSCAL v1.1.2 JSON schema files into this repo's |
After review with @mpemy we have learned that the published NIST OSCAL JSON schema definitions continue to be incompatible as references for the OpenAPI definition as-is. We will continue using the manually adjusted version of those files for the foreseeable future, and will place this issue back on hold. Possible future steps include:
|
As part of a previous issue, it was found that the JSON schemas NIST produces contain
$ref
elements by$id
rather than path which seems to only be supported in OpenAPI v3.1 (and Swagger UI hasn't caught up to that yet). See GitHub commentWe’ve also submitted a feature request to another NIST repo that facilitates the pipeline that creates the OSCAL JSON schemas: usnistgov/metaschema#160
As a result, in we forked the NIST OSCAL repo and 'manually' changed the JSON schemas to ref by path.
If/when NIST updates their JSON schemas or Swagger supports OpenAPI v3.1 we should revert the OSCAL REST API definition to reference NIST GitHub JSON schemas rather than our fork.
The text was updated successfully, but these errors were encountered: