-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add the possibility to reorder the repositories #9912
Add the possibility to reorder the repositories #9912
Conversation
add: order repo by order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please install vscode prettier extension to remove extra blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! 👍 Just some small inline comments
I notice when adding a repo, it doesn't appear on the list until the page is refresh, but this bug doesn't exist in production
Hi @eddiejaoude checked out the adding part and that is true! Working to fix that! |
Fix adding not shown repo until reload issue
Okay @eddiejaoude i fixed all previous issues, it should be okay by now! |
Sorry, on this now 👍 |
Definitely! must have losed it while fixing things! Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes. I just tested it and on the manage profile page it is ordered but on the public profile http://localhost:3000/eddiejaoude?tab=repos
the repos are not ordered, I think this API also needs a change pages/api/profiles/[username]/index.js
?
Sorry for the delay! Yes you're right, fixing it rn! |
[ fix ] ordered repos on public profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍 Thank you
Fixes Issue
Closes #9810
Changes proposed
I added the possibility to reorder the user repository.
When the repos are returned, they are retrieved in saved order.
The mechanic used is the same as for user links reordering, just adjusted it a bit
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers