Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add the possibility to reorder the repositories #9912

Merged
merged 20 commits into from
Mar 23, 2024

Conversation

Giuliano1993
Copy link
Contributor

@Giuliano1993 Giuliano1993 commented Dec 15, 2023

Fixes Issue

Closes #9810

Changes proposed

I added the possibility to reorder the user repository.
When the repos are returned, they are retrieved in saved order.
The mechanic used is the same as for user links reordering, just adjusted it a bit

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2023-12-15 222102
Screenshot 2023-12-15 222122
Screenshot 2023-12-15 222147

Note to reviewers

@github-actions github-actions bot added models issue linked Pull Request has issue linked labels Dec 15, 2023
Copy link
Contributor

@badrivlog badrivlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install vscode prettier extension to remove extra blank line

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! 👍 Just some small inline comments

I notice when adding a repo, it doesn't appear on the list until the page is refresh, but this bug doesn't exist in production

@Giuliano1993
Copy link
Contributor Author

Hi @eddiejaoude checked out the adding part and that is true! Working to fix that!

Fix adding not shown repo until reload issue
@Giuliano1993
Copy link
Contributor Author

Okay @eddiejaoude i fixed all previous issues, it should be okay by now!

@eddiejaoude
Copy link
Member

Sorry, on this now 👍

Definitely! must have losed it while fixing things!

Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes. I just tested it and on the manage profile page it is ordered but on the public profile http://localhost:3000/eddiejaoude?tab=repos the repos are not ordered, I think this API also needs a change pages/api/profiles/[username]/index.js?

@Giuliano1993
Copy link
Contributor Author

Sorry for the delay! Yes you're right, fixing it rn!

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍 Thank you

@eddiejaoude eddiejaoude merged commit 2609779 into EddieHubCommunity:main Mar 23, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Re-ordering repos
3 participants