From e93860f8445ea7682096d79b7dab2c7dc2626814 Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Thu, 25 Apr 2024 11:16:02 +0800
Subject: [PATCH] ui/network: add error handing for dbus  `call` (#32164)

old-commit-hash: d7d378aeefb10b9194e14534b075615216b117af
---
 selfdrive/ui/qt/network/wifi_manager.cc | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/selfdrive/ui/qt/network/wifi_manager.cc b/selfdrive/ui/qt/network/wifi_manager.cc
index c7991990eb21f1..717da47096913e 100644
--- a/selfdrive/ui/qt/network/wifi_manager.cc
+++ b/selfdrive/ui/qt/network/wifi_manager.cc
@@ -1,5 +1,7 @@
 #include "selfdrive/ui/qt/network/wifi_manager.h"
 
+#include <utility>
+
 #include "selfdrive/ui/ui.h"
 #include "selfdrive/ui/qt/widgets/prime.h"
 
@@ -14,9 +16,15 @@ bool compare_by_strength(const Network &a, const Network &b) {
 
 template <typename T = QDBusMessage, typename... Args>
 T call(const QString &path, const QString &interface, const QString &method, Args &&...args) {
-  QDBusInterface nm = QDBusInterface(NM_DBUS_SERVICE, path, interface, QDBusConnection::systemBus());
+  QDBusInterface nm(NM_DBUS_SERVICE, path, interface, QDBusConnection::systemBus());
   nm.setTimeout(DBUS_TIMEOUT);
-  QDBusMessage response = nm.call(method, args...);
+
+  QDBusMessage response = nm.call(method, std::forward<Args>(args)...);
+  if (response.type() == QDBusMessage::ErrorMessage) {
+    qCritical() << "DBus call error:" << response.errorMessage();
+    return T();
+  }
+
   if constexpr (std::is_same_v<T, QDBusMessage>) {
     return response;
   } else if (response.arguments().count() >= 1) {