From 680cfd4605b35f16be417353bf9c100920599fd8 Mon Sep 17 00:00:00 2001
From: Elsio Sanchez <45974454+elsiosanchez@users.noreply.github.com>
Date: Fri, 11 Aug 2023 21:48:05 -0400
Subject: [PATCH] Fix Full Grid Mode Scroll Window bug (#1285)

---
 src/views/ADempiere/Window/DocumentWindow.vue      | 14 ++++++++++++--
 src/views/ADempiere/Window/Finances.vue            | 14 ++++++++++++--
 src/views/ADempiere/Window/GeneralLedger.vue       | 14 ++++++++++++--
 src/views/ADempiere/Window/MaterialsManagement.vue | 14 ++++++++++++--
 src/views/ADempiere/Window/MultiTabWindow.vue      | 14 ++++++++++++--
 5 files changed, 60 insertions(+), 10 deletions(-)

diff --git a/src/views/ADempiere/Window/DocumentWindow.vue b/src/views/ADempiere/Window/DocumentWindow.vue
index 3f7adf544a1..91b7d121d9c 100644
--- a/src/views/ADempiere/Window/DocumentWindow.vue
+++ b/src/views/ADempiere/Window/DocumentWindow.vue
@@ -32,7 +32,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -222,6 +222,15 @@ export default defineComponent({
       return isEmptyValue(record) ? action : record
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -255,7 +264,8 @@ export default defineComponent({
       isViewFullScreenChild,
       isViewFullScreenParent,
       sizeTab,
-      sizeTabChild
+      sizeTabChild,
+      styleScroll
     }
   }
 
diff --git a/src/views/ADempiere/Window/Finances.vue b/src/views/ADempiere/Window/Finances.vue
index 498fc6bf9f1..33e122bb8db 100644
--- a/src/views/ADempiere/Window/Finances.vue
+++ b/src/views/ADempiere/Window/Finances.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -209,6 +209,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -246,7 +255,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }
 
diff --git a/src/views/ADempiere/Window/GeneralLedger.vue b/src/views/ADempiere/Window/GeneralLedger.vue
index 4c4d27edf6a..4d521f012cd 100644
--- a/src/views/ADempiere/Window/GeneralLedger.vue
+++ b/src/views/ADempiere/Window/GeneralLedger.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -209,6 +209,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -246,7 +255,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }
 
diff --git a/src/views/ADempiere/Window/MaterialsManagement.vue b/src/views/ADempiere/Window/MaterialsManagement.vue
index 88cfca27d89..03f19a3dc33 100644
--- a/src/views/ADempiere/Window/MaterialsManagement.vue
+++ b/src/views/ADempiere/Window/MaterialsManagement.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -212,6 +212,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -248,7 +257,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }
 
diff --git a/src/views/ADempiere/Window/MultiTabWindow.vue b/src/views/ADempiere/Window/MultiTabWindow.vue
index e8273054d85..26df72502cc 100644
--- a/src/views/ADempiere/Window/MultiTabWindow.vue
+++ b/src/views/ADempiere/Window/MultiTabWindow.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
 
       <modal-dialog
@@ -214,6 +214,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -251,7 +260,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }