Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable native target publishing #192

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

ccjernigan
Copy link
Contributor

@ccjernigan ccjernigan commented May 22, 2023

Native targets should not yet be published, because CI infrastructure needs to be updated #163

Native target publishing is left enabled for snapshots, so that we can test how the multiplatform integration is working.

Note
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review your own code in GitHub's web interface1
  • Add automated tests as appropriate
  • Check the code coverage2 report for the automated tests
  • Update documentation as appropriate (e.g README.md, etc.)
  • Pull in the latest changes from the main branch and squash your commits before assigning a reviewer3

Reviewer

  • Check the code with the Code Review Guidelines checklist
  • Perform an ad hoc review4
  • Review the automated tests
  • Review the documentation, README.md, etc. as appropriate

Footnotes

  1. Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.

  2. While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check.

  3. Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

  4. In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.

Native targets should not yet be published, because CI infrastructure needs to be updated
#163

Native target publishing is left enabled for snapshots, so that we can test how the multiplatform integration is working.
@ccjernigan ccjernigan requested a review from HonzaR May 22, 2023 12:48
ORG_GRADLE_PROJECT_IS_SNAPSHOT: false
ORG_GRADLE_PROJECT_NATIVE_TARGETS_ENABLED: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to adding ORG_GRADLE_PROJECT_NATIVE_TARGETS_ENABLED, I sorted the rest of the values here.

@ccjernigan ccjernigan merged commit 8e5dc1a into main May 22, 2023
@ccjernigan ccjernigan deleted the disable-native-publishing branch May 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants