Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix theproblem forget to PluginObject #15821

Closed
wants to merge 1 commit into from
Closed

fix theproblem forget to PluginObject #15821

wants to merge 1 commit into from

Conversation

notcold
Copy link
Contributor

@notcold notcold commented May 31, 2019 •
edited
Loading

export const InfiniteScroll: PluginObject;
the PluginObject didnt import before

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@notcold
fix theproblem forget to PluginObject
4973861 
export const InfiniteScroll: PluginObject<ElInfiniteScroll>;
 the PluginObject  didnt import before
@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit 4973861

https://deploy-preview-15821--element.netlify.com

@notcold
Copy link
Contributor Author

notcold commented May 31, 2019

#15821

@notcold
Copy link
Contributor Author

notcold commented May 31, 2019

昨天修复问题引入PluginObject 并没有加import导致ts校验还是存在问题

@wizardnet972 wizardnet972 mentioned this pull request May 31, 2019
Closed
@marcomonsanto
Copy link

any updates on when will you merge?

@WaSheep
Copy link

WaSheep commented Jun 3, 2019

Duplicate of #15805

@WaSheep WaSheep marked this as a duplicate of #15805 Jun 3, 2019
@WaSheep WaSheep closed this Jun 3, 2019
@li1224632854
Copy link

为啥2.9.1版本 这个错误还是存在

@notcold
Copy link
Contributor Author

notcold commented Jun 19, 2019 •
edited
Loading

为啥2.9.1版本 这个错误还是存在

看git代码是修复，但是新修复的版本还没发布，所以建议还是先降一下版本
详见 #15802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@notcold @element-bot @marcomonsanto @WaSheep @li1224632854