-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix property and event names for popconfirm component #20240
Conversation
Deploy preview for element ready! Built with commit 9c43018 |
@iamkun take a look |
long time no see |
这种mr 也能合并,线上全部确认事件无效了 |
@wulucxy element 更新日志里都写了是不兼容升级 , 自己不看就乱升级线上环境 真是头铁 |
@xx45 去了解下 npm 版本规则,minor 版本是自动升级的。这种breaking change 放在 minor 版本要害死一堆程序员了 |
生产环境锁版本 这不是基本操作 |
@xx45 建议多参考业界的实践 |
版本控制也不是全部人都跟隨 semver 怕出事就最好用 當然最穩定做法是人手更新 |
这次也没有太多的更新,线上项目没有更新了 |
建议下次版本升级的时候进行兼容性处理,先同时保留confirm/cancel和onConfirm/onCancel两组事件,然后在3.x版本再将onConfirm/onCancel废弃 |
果然,除了客户端 |
Please make sure these boxes are checked before submitting your PR, thank you!
https://vuejs.org/v2/guide/components-custom-events.html