Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property and event names for popconfirm component #20240

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Fix property and event names for popconfirm component #20240

merged 2 commits into from
Oct 29, 2020

Conversation

hugiron
Copy link
Contributor

@hugiron hugiron commented Sep 26, 2020

Please make sure these boxes are checked before submitting your PR, thank you!
https://vuejs.org/v2/guide/components-custom-events.html

Vue.prototype.$emit = function (event) {
    // before
    var lowerCaseEvent = event.toLowerCase();
    // after
}

@element-bot
Copy link
Member

element-bot commented Sep 26, 2020

Deploy preview for element ready!

Built with commit 9c43018

https://deploy-preview-20240--element.netlify.app

@hugiron
Copy link
Contributor Author

hugiron commented Sep 26, 2020

@iamkun take a look
This fix is urgently needed

@ja-peng
Copy link

ja-peng commented Nov 5, 2020

long time no see

@wulucxy
Copy link

wulucxy commented Nov 5, 2020

这种mr 也能合并,线上全部确认事件无效了
???

@xx45
Copy link

xx45 commented Nov 5, 2020

@wulucxy element 更新日志里都写了是不兼容升级 , 自己不看就乱升级线上环境 真是头铁

@wulucxy
Copy link

wulucxy commented Nov 5, 2020

@xx45 去了解下 npm 版本规则,minor 版本是自动升级的。这种breaking change 放在 minor 版本要害死一堆程序员了

@xx45
Copy link

xx45 commented Nov 5, 2020

生产环境锁版本 这不是基本操作

@wulucxy
Copy link

wulucxy commented Nov 5, 2020

@xx45 建议多参考业界的实践
https://zhuanlan.zhihu.com/p/22934066

@climba03003
Copy link

climba03003 commented Nov 5, 2020

版本控制也不是全部人都跟隨 semver
例如很多人用的TypeSciprt X.Y.Z 當中 ``X.Y``` 都是主要版本

怕出事就最好用 ~X.Y.Z / X.Y.x 來做依賴版本管控
這樣不影響功能又可以更新Patch

當然最穩定做法是人手更新

@raydao
Copy link

raydao commented Nov 10, 2020

这次也没有太多的更新,线上项目没有更新了

@Jibacat
Copy link

Jibacat commented Nov 18, 2020

建议下次版本升级的时候进行兼容性处理,先同时保留confirm/cancel和onConfirm/onCancel两组事件,然后在3.x版本再将onConfirm/onCancel废弃

@furylee
Copy link

furylee commented Nov 27, 2020

建议下次版本升级的时候进行兼容性处理,先同时保留confirm/cancel和onConfirm/onCancel两组事件,然后在3.x版本再将onConfirm/onCancel废弃

果然,除了客户端

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants