Select:fix Select box jitter when the window is zoomed bug（对应issue：#21142） #21143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for element ready! 🔨 Explore the source changes: 5e150cb 🔍 Inspect the deploy log: https://app.netlify.com/sites/element/deploys/60edd46d0514810007436a3b 😎 Browse the preview: https://deploy-preview-21143--element.netlify.app/ |
|
Hi! Element UI team! Thanks for creating such an excellent UI library. Window zoom jitters when multiple selection occurs，The component is constantly updating its calculations，I think it is the jitter caused by the real-time calculation of the setting height within the component |
caoshining
changed the title
cs1707
reviewed
Jul 28, 2021
| @@ -795,7 +795,6 @@ | |||
|
|
|||
| handleResize() { | |||
| this.resetInputWidth(); | |||
| if (this.multiple) this.resetInputHeight(); | |||
There was a problem hiding this comment.
@cs1707 老哥 你看348 行已经监听value来重置高度了，handleResize的绑定那就会无限触发，只要我新增或者移除一个选项，你可以对比下看下348行 已经在重算和重置高度了 那你这行监听大小变化不久一直会触发了？无限循环了 只用value更改的时候重置就够了 你不信你可以跑一下我改的这个代码试下 解决了了这个issue ，麻烦看下 谢谢
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
移出动态监听致使持续重绘 导致的高度持续更改，解决对应问题 对应 #21142
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.