Feat/stateless auth sso #73
Conversation
…O Opaque token and generate session on server side
…O Opaque token and generate session on server side
| @@ -54,7 +46,14 @@ spring: | |||
| - undertow-https-redirect | |||
There was a problem hiding this comment.
this packaging is not used for local dev only but also for our docker image, do we want ldap by default ?
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectController.java
Show resolved
Hide resolved
...er/src/main/java/com/chutneytesting/security/infra/memory/InMemorySecurityConfiguration.java
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Show resolved
Hide resolved
|
chutney/server/src/main/java/com/chutneytesting/security/api/UserController.java
Show resolved
Hide resolved
| return extractClaim(token, Claims::getExpiration); | ||
| } | ||
|
|
||
| private String createToken(Map<String, Object> claims, String subject) { |
There was a problem hiding this comment.
Why not forge a token with an local issuer for chutney ? and add chutney authorizations as claims/scopes ?
| if (username != null && SecurityContextHolder.getContext().getAuthentication() == null) { | ||
| var userDetails = userDetailsServices.stream().map(service -> { | ||
| try { | ||
| return service.loadUserByUsername(username); |
There was a problem hiding this comment.
Why call the underlying user details service ? You need only to retrieve the chutney authorizations from the corresponding service given the username, i think.
| #SPDX-FileCopyrightText: 2017-2024 Enedis | ||
| #SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| spring: |
There was a problem hiding this comment.
Is all configs required here ? Seems a bit redondant.
| @@ -86,6 +86,10 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-security</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-oauth2-client</artifactId> | |||
There was a problem hiding this comment.
Are we not just a resource server ?
| oidc: | ||
| user-info-uri: "${auth.sso.issuer}/userinfo" | ||
|
|
||
| auth: |
There was a problem hiding this comment.
Please use chutney. as prefix
| - mem-auth | ||
| - db-sqlite | ||
|
|
||
| auth: |
There was a problem hiding this comment.
Please use .chutney prefix.
No description provided.