feat: optimizes translation helpers

kontent-ai-bot · Jan 21, 2020 · 3ab8400 · 3ab8400
1 parent cb37f7a
commit 3ab8400
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/core/codename-translate-helper.ts b/src/core/codename-translate-helper.ts
@@ -25,7 +25,8 @@ export class CodenameTranslateHelper {
                             }
                         }
                     }
-                    if (key !== '0') {
+
+                    if (typeof val === 'object' && val !== null) {
                         this.replaceIdReferencesWithCodenames(val, allData);
                     }
                 }
@@ -52,7 +53,7 @@ export class CodenameTranslateHelper {
                             }
                         }
                     }
-                    if (key !== '0') {
+                    if (typeof val === 'object' && val !== null) {
                         this.extractReferencedCodenames(val, allData, foundCodenames);
                     }
                 }
@@ -77,7 +78,7 @@ export class CodenameTranslateHelper {
                             return codename;
                         }
                     }
-                    if (key !== '0') {
+                    if (typeof val === 'object' && val !== null) {
                         foundCodename = this.tryFindCodenameForId(findId, val, foundCodename);
                     }
                 }

diff --git a/src/core/id-translate-helper.ts b/src/core/id-translate-helper.ts
@@ -27,7 +27,7 @@ export class IdTranslateHelper {
                         }
                     }
 
-                    if (key !== '0') {
+                    if (typeof val === 'object' && val !== null) {
                         this.replaceIdReferencesWithNewId(val, items);
                     }
                 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,7 @@ export class IdTranslateHelper { @@
                             }
                         }
-                        if (key !== '0') {
+                        if (typeof val === 'object' && val !== null) {
                             this.replaceIdReferencesWithNewId(val, items);
                         }
                     }
@@ Expand Down @@