Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display Coordinates Resolved for nonsense coordinates #3

Open
ojalaquellueva opened this issue Jun 18, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@ojalaquellueva
Copy link
Member

ojalaquellueva commented Jun 18, 2024

Current, hyperlinked values for Coordinates Resolved are displayed for nonsense coordinates with values outside the allowed range of -90:90 for latitude and -180:180 for latitude (Coordinate Status="Coordinate values out of bounds"). Nothing should be displayed in column Coordinates Resolved for coordinates with Coordinate Status="Coordinate values out of bounds" or Coordinate Status="Coordinates non-numeric". Values should only be displayed for coordinates which appear on the map.

@ojalaquellueva ojalaquellueva added the bug Something isn't working label Jun 18, 2024
@ojalaquellueva ojalaquellueva reopened this Jul 1, 2024
@ojalaquellueva
Copy link
Member Author

I have reopened this issue as out-of-bounds coordinates were still displaying. However, the main solution was with the API. I have updated the API to remove out-of-bounds coordinates from field latitude and longitude. However, there is still an additional problem on web app end: a single comma now displays for nonsense coordinates (both "out of bounds" and "non-numeric"). This is no doubt the result of concatenating the empty latitude and longitude columns with a comma delimiter. Please correct this behavior so that column Coordinates Resolved is completely blank for "out of bounds" and "non-numeric" coordinates.

@ojalaquellueva ojalaquellueva self-assigned this Jul 1, 2024
@ojalaquellueva
Copy link
Member Author

See ojalaquellueva/gvs#8 (completed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants