Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace System.Data.SqlClient with Microsoft.Data.SqlClient #38

Open
tsahi opened this issue Sep 26, 2020 · 5 comments
Open

Replace System.Data.SqlClient with Microsoft.Data.SqlClient #38

tsahi opened this issue Sep 26, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@tsahi
Copy link
Collaborator

tsahi commented Sep 26, 2020

Is your feature request related to a problem? Please describe.
Microsoft has announced that future development of their .NET SQL Server driver will be done in Microsoft.Data.SqlClient, released as a NuGet package for both .NET Core and .NET Framework. To keep with the latest developments, we need to use that instead of System.Data.SqlClient.

Describe the solution you'd like
This is mostly a find-and-replace of the namespace once the package is added.

Microsoft also maintains a NuGet package named System.Data.SqlClient, but all their publications promote Microsoft.Data.SqlClient.

@tsahi tsahi added the enhancement New feature or request label Sep 27, 2020
@tsahi tsahi added this to the 7.0 milestone Oct 10, 2020
@tsahi tsahi mentioned this issue Oct 31, 2020
@tsahi
Copy link
Collaborator Author

tsahi commented Nov 28, 2020

I'm contemplating if to replace System.Data.SqlClient with Microsoft.Data.SqlClient, or support both namespaces (as two separate packages), because users might not want to jump over to the Microsfot.Data.SqlClient wagon yet. What do you think?
@Chavoshi

@Chavoshi
Copy link
Member

Hi @tsahi,
I somehow do not agree with supporting both namespaces in do different packages, but the thing we can do is make it conditional for different frameworks, older frameworks can use the old namespace but .Net Core and new .Net Frameworks (we can decide about the frameworks) should use the new one, what do you think?

@tsahi
Copy link
Collaborator Author

tsahi commented Nov 29, 2020

Yes, we can do that. We can support the new namespace for the latest frameworks (.NET Framework 4.8 and .NET 5.0), and add a dependency on it for these versions. As the older frameworks go out of support from Microsoft (some already have), we can drop support for them and eventualy, a few years ahead, drop support for the old namespace entirely. Sounds right?

@Chavoshi
Copy link
Member

Right

@tsahi
Copy link
Collaborator Author

tsahi commented Feb 6, 2021

We will implement this when we add support for .NET 5 (#41) and .NET Framework 4.8, in a future release. See comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants