-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An empty (0b) archive log files are being created #7
Comments
vash6p
changed the title
A 0b archive log file are being created
An empty (0b) archive log files are being created
Nov 19, 2021
Hi @vash6p, |
Great,
when trying to push my branch. |
@vash6p , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The RollingFlatFileTraceListener is saving empty (0b) archive log files, while performing roll.
I've prepared an improvement/fix for this issue - an additional option to indicate whether to create an archive file even if it would be empty. The default value is "Always create", so the default behavior will not change.
@Chavoshi I'd be great if I could commit it and present in PR.
The funny thing is, the code regarding this functionality in the original .NET version of this library seems identical, yet empty archive files are not created, which I believe I desired for this implementation. :)
The text was updated successfully, but these errors were encountered: