Fix offsetarrays support #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
707
to
709
| @inline function to_rarray_internal( | ||
| @nospecialize(x::AbstractArray{<:ReactantPrimitive}), ::Tuple | ||
| @nospecialize(x::Array{<:ReactantPrimitive}), ::Tuple | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @inline function to_rarray_internal( | |
| @nospecialize(x::AbstractArray{<:ReactantPrimitive}), ::Tuple | |
| @nospecialize(x::Array{<:ReactantPrimitive}), ::Tuple | |
| ) | |
| @inline function to_rarray_internal(@nospecialize(x::Array{<:ReactantPrimitive}), ::Tuple) |
wsmoses
commented
Jan 3, 2025
| function Reactant.traced_type( | ||
| ::Type{<:OffsetArray{<:Any,N, T}}, seen::ST, ::Val{mode}, track_numbers | ||
| ) where {T, N,ST,mode} | ||
| T2 = Reactant.traced_type(T, seen, Val(mode), track_numbers) |
Member
Author
There was a problem hiding this comment.
@avik-pal so the reason this is necessary here is because the default conversion of ConcreteRArray breaks this where AFAICT OffsetArray is OffsetArray{ElType, Dim, ArrayType} which for a concreterarray is OffsetArray{Float64, 2, ConcreRMatrix{Float64}}. however the conversion of a TracedRArray is OffsetArray{TracedRNumber{Float64}, 2, TracedRMatrix{Float64}}.
The following code should always work, however.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.