ci: add cpp format check #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
approved these changes
Feb 13, 2025
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
Looks good, apart from splitting the formatting jobs in distinct workflows
.github/workflows/format-check.yml
Outdated
Comment on lines
32
to
38
| code-style-cpp: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: DoozyX/clang-format-lint-action@v0.18.2 | ||
| with: | ||
| source: 'deps' |
Member
There was a problem hiding this comment.
I think it'd be cleaner to have this as a separate workflow which runs only when touching C++ files. As it is now this is running also when touching Julia files only (and the Julia formatter runs unnecessarily when touching C++ files only)
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coping over from EnzymeJAX repo
All changes to the cpp files are from running clang-format