Return T if mode=TracedSetPath #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@avik-pal I don't want to distract you from mesh stuff, but can you potentially lend a hand here? |
Collaborator
|
what is the issue here? |
Member
|
CI is sad. Essentially the reason for this PR is because a data structure passed non-traced TwicePrecision{Float64} and StepRange into a traced if. TracedIf asks for tracednumbers, which are ilelgal for steprange [expected the inner elem to be an int]. This PR doesn't change the inner value types to change on a tracedtrack and related [since it should just update in place] |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
avik-pal
force-pushed
the
glw-wm/traced-set-path
branch
from
ae047d3 to
ee44bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.