fixed hamming distance normalization bug

EpistasisLab · Feb 11, 2021 · 8a26df1 · 8a26df1
1 parent 7795389
commit 8a26df1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/skrebate/relieff.py b/skrebate/relieff.py
@@ -312,7 +312,7 @@ def pre_normalize(x):
             d_dist = squareform(pdist(xd, metric='hamming'))
             # Cityblock is also known as Manhattan distance
             c_dist = squareform(pdist(pre_normalize(xc), metric='cityblock'))
-            return np.add(d_dist, c_dist) / self._num_attributes
+            return np.add(d_dist * self._num_attributes, c_dist)
 
         else: #continuous features only
             #xc = pre_normalize(xc)