Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Install Orion from local cloned repository #1068

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is a small PR to make dashboard testing CI use local cloned repository instead of distant branch git+https://github.com/notoraptor/orion.git@feature/benchmark_webapi_rebased#egg=orion[profet] to run orion server. We should not need anymore to use a separate branch for server since benchmarks web API is now merged into develop branch.

Changes

  • In Github Actions dashboard-src.yml, directly use local cloned repository to install Orion with extra profet

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@notoraptor notoraptor merged commit 09f22c6 into Epistimio:develop Jan 20, 2023
@notoraptor notoraptor deleted the make-ci-use-local-branch branch January 20, 2023 18:49
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
@notoraptor notoraptor added the ci label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants