Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knowledge Base + Multi-Task Warm-starting #933

Merged
merged 160 commits into from
Sep 30, 2022
Merged

Knowledge Base + Multi-Task Warm-starting #933

merged 160 commits into from
Sep 30, 2022

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented May 31, 2022 •
edited
Loading

No description provided.

lebrice and others added 24 commits May 16, 2022 12:26
@lebrice
Import files from old PR, start fresh
978be98 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Cleaning up algo_wrapper.py
e579f97 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Minor typing improvements in utils/__init__.py
0b0d78b 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
add transform-related methods to AlgoWrapper
0bdf0c9 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Clean up multi_task_algo.py
e3d2e0e 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
[big] move wrappers to folder, simplify wrappers
f99af06 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add tests for the wrappers
609ccc9 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Move algo wrappers to folder, split up tests a bit
591d085 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix cyclical import issue with knowledbe base
74011a2 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove accidentally added .pre-commit-config.yaml
177f276 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
"algorithms.algorithm" -> "algorithms.unwrapped"
5d9feef 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Have wrappers return the algo's config, not theirs
cf7d3ac 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove duplicated code from SpaceTransform
d5b2ac8 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Rename test files for algo wrappers
8cd3adb 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix bug in test_gridsearch.py
55702a8 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove more duplicated code from SpaceTransform
c835e4c 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Husk of unit tests for multi-task wrapper
87041d6 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Rename multi_task_wrapper.py -> multi_task.py
9fdfd84 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Start to write body of the test
4b43796 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove other duplicate methods of SpaceTransform
a0a2517 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add dataclasses for various objects
926c05a 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Adapting previous changes from config_dataclasses
e556851 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Adapting previous changes from config_dataclasses
8e84147 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Merge branch 'knowledge-base' of https://www.github.com/lebrice/orion …
1e72b4e 
…into knowledge-base

Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Copy link
Collaborator Author

lebrice commented Jun 8, 2022 •
edited
Loading

Might be a good idea to review what is currently here. From my perspective, the main thing left is to add is some unit tests.

@lebrice lebrice marked this pull request as ready for review June 8, 2022 13:10
@lebrice
Add tests to increase coverage of Registry class
3c7141e 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add more coverage for _instantiate_knowledge_base
34965b4 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add a bit more coverage for AlgoWrapper
cb616d2 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix bug in _instantiate_knowledge_base
84de58b 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add tests for _instantiate_algo
5040c07 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add generic test class for AlgoWrappers
bc02974 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Remove redundant fixture in AlgoWrapper tests
57d561b 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Clean / minor changes to test_knowledge_base.py
a007076 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Use asserts to avoid writing useless tests
8f23392 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add test case for no compatible trials found
3555408 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Clean up testing utility function a bit
9977d87 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add test for not warm-starting twice
aff8c7b 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add test for "space already has task_id" error
47d8a95 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add tests for is_warmstarteable function
0d25b26 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Standardize the imports of ExperimentConfig
5bd51af 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx
Copy link
Member

bouthilx commented Sep 21, 2022 •
edited
Loading

The failing test is not related to this PR. Looks like develop needs to be fixed.

@lebrice
Add more tests for _instantiate_kb
3f35bba 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Remove redundante else clause in _instantiate_algo
5a61b59 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
bouthilx
bouthilx approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quite some work! Good job! :)

@lebrice lebrice merged commit 06e6be9 into Epistimio:develop Sep 30, 2022
@bouthilx bouthilx added the feature Introduces a new feature label Dec 19, 2022
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lebrice @bouthilx