Skip to content
This repository has been archived by the owner on Feb 5, 2023. It is now read-only.

Incompatible with scout 4 #95

Closed
IgorDePaula opened this issue Feb 13, 2018 · 5 comments
Closed

Incompatible with scout 4 #95

IgorDePaula opened this issue Feb 13, 2018 · 5 comments

Comments

@IgorDePaula
Copy link

Incompatible with scout 4? Not install with laravel/scout 4

@kronthto
Copy link
Contributor

I took a quick look at the changes in laravel/scout v4 (https://github.com/laravel/scout/compare/3.0...4.0?w=1, didn't find a Changelog / Upgrading file sadly?) and it seems to boil down to:

  • Drop PHP5 Support
  • saved event rather than created&updated
  • Whether or not to index an entity conditional by shouldBeSearchable
  • Default sync behaviour I don't fully understand: Sync conditional models laravel/scout#264

IMHO nothing too bad, probably the only thing that is blocking right now is the constraint in composer.json (or did you get another error?):

"laravel/scout": "^3.0",

Maybe it'll just work if we change it to ^3.0|^4.0; I will do some tests on this if I find the time.

@IgorDePaula
Copy link
Author

Seriuos? Only this? I do this, but is not the ideal.

@loranger
Copy link

Could we have an ETA, on this upgrade, please @ErickTamayo ?

@kronthto
Copy link
Contributor

kronthto commented Apr 8, 2018

I did some more research and tests on this, with the conclusion that adjusting the version constraint is enough. See #99.

IllyaMoskvin added a commit to art-institute-of-chicago/laravel-scout-elastic that referenced this issue May 4, 2018
Merging from upstream to add compatibility with laravel/scout ^4.0.

ErickTamayo/laravel-scout-elastic#99
ErickTamayo/laravel-scout-elastic#95
@ErickTamayo
Copy link
Owner

Closing due to age. a new version for Laravel 8 was released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants