From 37940e7268e0d4ea8628d23c3b26e3d4ab22877a Mon Sep 17 00:00:00 2001 From: john gravois Date: Wed, 28 Feb 2018 08:54:57 -0800 Subject: [PATCH 1/3] chore(npm packages): remove test files and tsconfig.json from npm tarballs AFFECTS PACKAGES: @esri/arcgis-rest-auth @esri/arcgis-rest-common-types @esri/arcgis-rest-feature-service @esri/arcgis-rest-geocoder @esri/arcgis-rest-groups @esri/arcgis-rest-items @esri/arcgis-rest-request ISSUES CLOSED: #132 --- packages/arcgis-rest-auth/package.json | 4 ++++ packages/arcgis-rest-common-types/package.json | 1 + packages/arcgis-rest-feature-service/package.json | 4 ++++ packages/arcgis-rest-geocoder/package.json | 4 ++++ packages/arcgis-rest-groups/package.json | 4 ++++ packages/arcgis-rest-items/package.json | 4 ++++ packages/arcgis-rest-request/package.json | 4 ++++ 7 files changed, 25 insertions(+) diff --git a/packages/arcgis-rest-auth/package.json b/packages/arcgis-rest-auth/package.json index 2fac5dd78b..3bbc05e073 100644 --- a/packages/arcgis-rest-auth/package.json +++ b/packages/arcgis-rest-auth/package.json @@ -8,6 +8,10 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", + "files": [ + "src/**", + "dist/**" + ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-common-types/package.json b/packages/arcgis-rest-common-types/package.json index e057e11ebd..771589b69d 100644 --- a/packages/arcgis-rest-common-types/package.json +++ b/packages/arcgis-rest-common-types/package.json @@ -5,6 +5,7 @@ "types": "dist/types/index.d.ts", "author": "", "license": "Apache-2.0", + "files": [], "scripts": { "prepare": "npm run build", "build": "npm run build:esm", diff --git a/packages/arcgis-rest-feature-service/package.json b/packages/arcgis-rest-feature-service/package.json index 9d81027e0f..048acbb333 100644 --- a/packages/arcgis-rest-feature-service/package.json +++ b/packages/arcgis-rest-feature-service/package.json @@ -8,6 +8,10 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", + "files": [ + "src/**", + "dist/**" + ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-geocoder/package.json b/packages/arcgis-rest-geocoder/package.json index cf173c03ad..cb2d5226b4 100644 --- a/packages/arcgis-rest-geocoder/package.json +++ b/packages/arcgis-rest-geocoder/package.json @@ -8,6 +8,10 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", + "files": [ + "src/**", + "dist/**" + ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-groups/package.json b/packages/arcgis-rest-groups/package.json index 210eb8649b..22b20d1a75 100644 --- a/packages/arcgis-rest-groups/package.json +++ b/packages/arcgis-rest-groups/package.json @@ -8,6 +8,10 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", + "files": [ + "src/**", + "dist/**" + ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-items/package.json b/packages/arcgis-rest-items/package.json index 6884a1dfae..f3b16eddda 100644 --- a/packages/arcgis-rest-items/package.json +++ b/packages/arcgis-rest-items/package.json @@ -8,6 +8,10 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", + "files": [ + "src/**", + "dist/**" + ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-request/package.json b/packages/arcgis-rest-request/package.json index 68fb26cad0..691fb2096e 100644 --- a/packages/arcgis-rest-request/package.json +++ b/packages/arcgis-rest-request/package.json @@ -11,6 +11,10 @@ "dependencies": { "tslib": "^1.7.1" }, + "files": [ + "src/**", + "dist/**" + ], "scripts": { "prepare": "npm run build", "build": "npm run build:node && npm run build:umd && npm run build:esm", From 754989f4a2ccc029d848d6d919d2a9286b7ddaf9 Mon Sep 17 00:00:00 2001 From: john gravois Date: Wed, 28 Feb 2018 09:18:42 -0800 Subject: [PATCH 2/3] add note to FAQ to explain tslib dependency --- docs/FAQ.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/FAQ.md b/docs/FAQ.md index 7df6af71d8..a46680715e 100644 --- a/docs/FAQ.md +++ b/docs/FAQ.md @@ -24,3 +24,5 @@ Using TypeScript allows us to add type information to request params and respons TypeScript compiles to JavaScript so you can use @esri/arcgis-rest-js in any JavaScript project. However if you use TypeScript you will get the benefits of type checking for free. We also _really_ like TypeScript because it supports exporting to both [ES 2015 modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import) (use `import`/`export`) and [UMD](http://davidbcalhoun.com/2014/what-is-amd-commonjs-and-umd/) modules. This allows us to support a wide variety of module loaders and bundlers, including Browserify, Webpack, RequireJS, and Dojo 1 and 2. + +We include [`tslib`](https://www.npmjs.com/package/tslib) as a dependency of individual npm packages to make usage of `_extends` and `_assign` in our compiled code more concise. \ No newline at end of file From 4dae6c055a2086763ad634bbc972ee45f9bc297b Mon Sep 17 00:00:00 2001 From: john gravois Date: Wed, 28 Feb 2018 13:22:58 -0800 Subject: [PATCH 3/3] dont use the src luke --- packages/arcgis-rest-auth/package.json | 5 +---- packages/arcgis-rest-feature-service/package.json | 5 +---- packages/arcgis-rest-geocoder/package.json | 5 +---- packages/arcgis-rest-groups/package.json | 5 +---- packages/arcgis-rest-items/package.json | 5 +---- packages/arcgis-rest-request/package.json | 5 +---- 6 files changed, 6 insertions(+), 24 deletions(-) diff --git a/packages/arcgis-rest-auth/package.json b/packages/arcgis-rest-auth/package.json index 3bbc05e073..ec2ba01710 100644 --- a/packages/arcgis-rest-auth/package.json +++ b/packages/arcgis-rest-auth/package.json @@ -8,10 +8,7 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", - "files": [ - "src/**", - "dist/**" - ], + "files": [ "dist/**" ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-feature-service/package.json b/packages/arcgis-rest-feature-service/package.json index 048acbb333..5a6b609822 100644 --- a/packages/arcgis-rest-feature-service/package.json +++ b/packages/arcgis-rest-feature-service/package.json @@ -8,10 +8,7 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", - "files": [ - "src/**", - "dist/**" - ], + "files": [ "dist/**" ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-geocoder/package.json b/packages/arcgis-rest-geocoder/package.json index cb2d5226b4..ec3debb17b 100644 --- a/packages/arcgis-rest-geocoder/package.json +++ b/packages/arcgis-rest-geocoder/package.json @@ -8,10 +8,7 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", - "files": [ - "src/**", - "dist/**" - ], + "files": [ "dist/**" ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-groups/package.json b/packages/arcgis-rest-groups/package.json index 22b20d1a75..f99501c79e 100644 --- a/packages/arcgis-rest-groups/package.json +++ b/packages/arcgis-rest-groups/package.json @@ -8,10 +8,7 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", - "files": [ - "src/**", - "dist/**" - ], + "files": [ "dist/**" ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-items/package.json b/packages/arcgis-rest-items/package.json index f3b16eddda..a3729caef9 100644 --- a/packages/arcgis-rest-items/package.json +++ b/packages/arcgis-rest-items/package.json @@ -8,10 +8,7 @@ "js:next": "dist/esm/index.js", "types": "dist/esm/index.d.ts", "license": "Apache-2.0", - "files": [ - "src/**", - "dist/**" - ], + "files": [ "dist/**" ], "dependencies": { "tslib": "^1.7.1" }, diff --git a/packages/arcgis-rest-request/package.json b/packages/arcgis-rest-request/package.json index 691fb2096e..468cf1d639 100644 --- a/packages/arcgis-rest-request/package.json +++ b/packages/arcgis-rest-request/package.json @@ -11,10 +11,7 @@ "dependencies": { "tslib": "^1.7.1" }, - "files": [ - "src/**", - "dist/**" - ], + "files": [ "dist/**" ], "scripts": { "prepare": "npm run build", "build": "npm run build:node && npm run build:umd && npm run build:esm",