Skip to content

Commit

Permalink
chore: drop unnecessary double build type workaround since components…
Browse files Browse the repository at this point in the history
….d.ts is now tracked (#8199)

**Related Issue:** #8108 

## Summary

Follow up from
#8108 (review).

Co-authored-by: Ben Elan <no-reply@benelan.dev>
  • Loading branch information
jcfranco and benelan committed Dec 1, 2023
1 parent 65a4f85 commit b0cc797
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 24 deletions.
1 change: 0 additions & 1 deletion packages/calcite-components-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"private": true,
"scripts": {
"ng": "ng",
"prebuild": "./support/stencilDoubleBuildTypesWorkaround.sh",
"prepublishOnly": "./support/prepublishBuildForCorrectVersion.sh",
"build": "ng build",
"clean": "rimraf dist node_modules .turbo .angular projects/component-library/dist"
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion packages/calcite-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"lint:scss": "stylelint --fix \"src/**/*.scss\" && prettier --write \"**/*.scss\" >/dev/null",
"lint:ts": "eslint --ext .ts,.tsx --fix . && prettier --write \"**/*.ts?(x)\" >/dev/null",
"posttest": "npm run test:prerender",
"prepublishOnly": "./support/stencilDoubleBuildTypesWorkaround.sh",
"prepublishOnly": "./support/buildForPreambleVersion.sh",
"release:docs": "npm run docs && storybook-to-ghpages --existing-output-dir=docs",
"start": "npm run util:clean-js-files && concurrently --kill-others --raw \"tsc --project ./tsconfig-demos.json --watch\" \"npm run build:watch-dev -- --serve\"",
"test": "stencil test --no-docs --no-build --spec --e2e",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
#!/usr/bin/env sh

# This script builds the stencil components and ensures
# the types are generated correctly as a workaround for
# https://github.com/ionic-team/stencil/issues/3239
#
# It runs in the prepublishOnly NPM script hook
# to prevent releasing with type bugs, and because
# it needs to execute after versioning so that the
# preamble in the dist source code is correct.
# This runs in the prepublishOnly NPM script hook after versioning
# so that the preamble in the dist source code is correct.
#
# Refs:
# https://github.com/lerna/lerna/blob/main/libs/commands/publish/README.md#lifecycle-scripts
Expand Down

0 comments on commit b0cc797

Please sign in to comment.