Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stepper Item] Enhance component's interactive states #10000

Closed
2 of 7 tasks
geospatialem opened this issue Aug 8, 2024 · 5 comments
Closed
2 of 7 tasks

[Stepper Item] Enhance component's interactive states #10000

geospatialem opened this issue Aug 8, 2024 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2024-10-29 - Oct ...

Comments

@geospatialem
Copy link
Member

Check existing issues

Description

Updates the stepper-item's interactive states as part of the larger epic in #9299.

Current state

image

Acceptance Criteria

  • Update the component's :press state background color to foreground.3

image

Relevant Info

Figma file

Which Component

stepper-item

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. ready for dev Issues ready for development implementation. labels Aug 8, 2024
@geospatialem geospatialem mentioned this issue Aug 8, 2024
Open
27 tasks
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added this to the 2024-10-29 - Oct Release milestone Aug 8, 2024
@geospatialem geospatialem removed needs triage Planning workflow - pending design/dev review. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Aug 8, 2024
@aPreciado88 aPreciado88 self-assigned this Oct 2, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 2, 2024
@aPreciado88 aPreciado88 mentioned this issue Oct 2, 2024
Merged
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 2, 2024
aPreciado88 added a commit that referenced this issue Oct 2, 2024
@aPreciado88
feat(stepper-item): update component's active state background color. (…
739bb46 
…#10475)

**Related Issue:**
[#10000](#10000)

## Summary

-Add `bg-foreground-3` to the component's `active` state.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Oct 2, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 3, 2024

@aPreciado88 It looks like this is not working as expected the background color is not being applied when the stepper-item is active, when clicked or when set to active in dev tools.
Screenshot 2024-10-03 at 9 27 29 AM

While fiddling around I toggled off the style of "display: contents" the active state background appears as expected.
image

@DitwanP DitwanP added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 3, 2024
@DitwanP DitwanP assigned aPreciado88 and unassigned geospatialem and DitwanP Oct 3, 2024
@aPreciado88 aPreciado88 mentioned this issue Oct 4, 2024
Merged
aPreciado88 added a commit that referenced this issue Oct 9, 2024
@aPreciado88
feat(stepper-item): update component's active state background color (#…
26aec11 
…10487)

**Related Issue:**
[#10000](#10000)

## Summary

Add `bg-foreground-3` to the component's `active` state.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 9, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Oct 14, 2024

🍡 Verified on 2.14.0-next.13
https://codepen.io/Ditwan-Price/pen/RwXpjXz?editors=100

@DitwanP DitwanP closed this as completed Oct 14, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88