Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Enhance component's interactive states #10001

Closed
5 of 9 tasks
geospatialem opened this issue Aug 8, 2024 · 3 comments
Closed
5 of 9 tasks

[Menu] Enhance component's interactive states #10001

geospatialem opened this issue Aug 8, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2024-12-17 - Dec ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Aug 8, 2024 •
edited
Loading

Check existing issues

Description

Updates the menu's interactive states as part of the larger epic in #9299.

Current state

image

Acceptance Criteria

  • Remove the background color on :hover and :focus to match stepper, tabs and pagination
  • Add border.2 2px bottom border on :hover to match tabs and pagination
  • Increase :active state bottom border to 4px on :focus

image

Relevant Info

Figma file

Which Component

menu

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. ready for dev Issues ready for development implementation. labels Aug 8, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@geospatialem geospatialem mentioned this issue Aug 8, 2024
Open
27 tasks
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

cc @geospatialem, @brittneytewks

@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 8, 2024
@geospatialem geospatialem added this to the 2024-12-17 - Dec Release milestone Aug 8, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@aPreciado88 aPreciado88 self-assigned this Nov 28, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 28, 2024
@aPreciado88 aPreciado88 mentioned this issue Dec 2, 2024
Merged
aPreciado88 added a commit that referenced this issue Dec 3, 2024
@aPreciado88
feat(menu-item): enhance component's interactive states (#10933)
581cea2 
**Related Issue:**
[#10001](#10001)

## Summary

This:
- Removes the background color on `:hover` and `:focus`.
- Adds `border.2` `2px` bottom border on `:hover`.
- Increases `:active` state `bottom border` to `4px` on `:focus`.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 3, 2024
@geospatialem
Copy link
Member Author

Verified on 3.0.0-next.46.

@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88