Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Some slotted content appears below or overlaps the header/footer #10095

Closed
2 of 6 tasks
ellenupp opened this issue Aug 16, 2024 · 9 comments
Closed
2 of 6 tasks

[Dialog] Some slotted content appears below or overlaps the header/footer #10095

ellenupp opened this issue Aug 16, 2024 · 9 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-11-26 - 3.0....

Comments

@ellenupp
Copy link

Check existing issues

Actual Behavior

When slotting absolute positioned content into the default slot of the dialog, it can appear below the header and overlap with the footer and its contents. We use shell in modal, and I don't think we can work around this by adjusting its positioning.

Here is a shell in the dialog's default slot. Notice the first action is hidden below the header, the footer bar is missing and the content overlaps the footer buttons.
image

vs the same content in modal's content slot
image

Expected Behavior

Same as modal, all content should appear between the header and footer.

Reproduction Sample

https://codepen.io/ellupp/pen/LYKOmPa?editors=1101

Reproduction Steps

  1. click button to open dialog and observe

Reproduction Version

2.11.1

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Dashboards
@ellenupp ellenupp added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 16, 2024
@github-actions github-actions bot added ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 16, 2024
@DitwanP DitwanP added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library and removed p - low Issue is non core or affecting less that 10% of people using the library labels Aug 19, 2024
@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 19, 2024
@DitwanP DitwanP added this to the 2024-08-27 - Aug Release milestone Aug 19, 2024
driskull added a commit that referenced this issue Aug 19, 2024
@driskull
fix(dialog): allow shell to be slotted inside. #10095
4de79b2
@driskull driskull mentioned this issue Aug 19, 2024
Closed
@driskull driskull added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 19, 2024
@driskull driskull removed their assignment Aug 19, 2024
@driskull
Copy link
Member

The issue is actually with the shell component. The shell component is positioned absolutely, so it doesn't slot well into dialog.

@DitwanP DitwanP added spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed estimate - 3 A day or two of work, likely requires updates to tests. labels Aug 19, 2024
driskull added a commit that referenced this issue Aug 20, 2024
@driskull
fix(dialog): allow shell to be slotted inside #10095
5ca3bf9
This was referenced Aug 20, 2024
Merged
Closed
@driskull driskull self-assigned this Aug 20, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Aug 20, 2024
@geospatialem
Copy link
Member

Summarizing our internal conversations, but due to some regressions with the above, we will be reverting the change above, and re-evaluating next steps in the 3.0, or November release.

cc @driskull @jcfranco @ellenupp

@geospatialem geospatialem reopened this Oct 10, 2024
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed 4 - verified Issues that have been released and confirmed resolved. labels Oct 10, 2024
@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Oct 10, 2024
@jcfranco
Copy link
Member

Per our conversation, we'll look at rolling back #10496, and addressing this issue, once #10241 lands in the November release.

driskull added a commit that referenced this issue Oct 10, 2024
@driskull
revert(panel): revert relative positioning on content (#10496)
239f4da 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
benelan pushed a commit that referenced this issue Oct 11, 2024
@driskull @benelan
revert(panel): revert relative positioning on content (#10496)
4aa39b2 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
benelan pushed a commit that referenced this issue Oct 11, 2024
@driskull @benelan
revert(panel): revert relative positioning on content (#10496)
e8cc258 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
@jcfranco jcfranco mentioned this issue Nov 16, 2024
Merged
@jcfranco jcfranco self-assigned this Nov 16, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Nov 16, 2024
jcfranco added a commit that referenced this issue Nov 18, 2024
@jcfranco
fix(dialog, panel): restore relative positioning in content area (#10749
6302897 
)

**Related Issue:** #10095 

## Summary

Fixes layout issues in dialog and panel content area.

This reverts commit 239f4da.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 18, 2024
alisonailea pushed a commit that referenced this issue Nov 19, 2024
@jcfranco @alisonailea
fix(dialog, panel): restore relative positioning in content area (#10749
8448cbf 
)

**Related Issue:** #10095 

## Summary

Fixes layout issues in dialog and panel content area.

This reverts commit 239f4da.
@DitwanP
Copy link
Contributor

DitwanP commented Nov 19, 2024

🍡 Verified on 3.0.0-next.16

@DitwanP DitwanP closed this as completed Nov 19, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
5 participants
@jcfranco @driskull @geospatialem @ellenupp @DitwanP