Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] setFocus doesn't work when filter is enabled #10136

Closed
2 of 6 tasks
ellenupp opened this issue Aug 21, 2024 · 3 comments
Closed
2 of 6 tasks

[List] setFocus doesn't work when filter is enabled #10136

ellenupp opened this issue Aug 21, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-08-27 - Aug ...

Comments

@ellenupp
Copy link

Check existing issues

Actual Behavior

Calling a list's setFocus when it has filter-enabled does not focus the list or any of its child elements.

Expected Behavior

When the filter is enabled, setFocus should place focus on the list's input.

Reproduction Sample

https://codepen.io/ellupp/pen/abgYKWM?editors=1010

Reproduction Steps

  1. Click "focus list" button. Nothing happens.
  2. Compare when removing filter-enabled from the list. Click the button -> first list item is focused.

Reproduction Version

2.11.1

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Dashboards
@ellenupp ellenupp added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 21, 2024
@github-actions github-actions bot added ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 21, 2024
@driskull
Copy link
Member

I think this is actually an issue with the filter component.

https://codepen.io/driskull/pen/MWMVqmb?editors=1010

driskull added a commit that referenced this issue Aug 23, 2024
@driskull
fix(filter): fix setFocus method. #10136
eafc160
@driskull driskull mentioned this issue Aug 23, 2024
Merged
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 23, 2024
@jcfranco jcfranco added this to the 2024-08-27 - Aug Release milestone Aug 23, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 23, 2024
driskull added a commit that referenced this issue Aug 23, 2024
@driskull
fix(filter): fix setFocus method (#10149)
f4a959a 
**Related Issue:** #10136

## Summary

- fix setFocus method
- update test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Aug 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Aug 23, 2024

🍡 Verified on 2.12.0-next.31
https://codepen.io/Ditwan-Price/pen/yLdjpwM?editors=1010

@DitwanP DitwanP closed this as completed Aug 23, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
5 participants
@jcfranco @driskull @geospatialem @ellenupp @DitwanP