Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader no longer animating #10182

Closed
2 of 6 tasks
COV-GIS opened this issue Aug 29, 2024 · 4 comments
Closed
2 of 6 tasks

Loader no longer animating #10182

COV-GIS opened this issue Aug 29, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2.12.1 patch

Comments

@COV-GIS
Copy link

COV-GIS commented Aug 29, 2024

Check existing issues

Actual Behavior

Loader no longer animating.

Expected Behavior

Loader should be animated.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/loader/

Reproduction Steps

I came across this with button loading: https://developers.arcgis.com/calcite-design-system/components/button/ Check loading property checkbox.

Can also be seen on any reference page when the sample is loading.

Reproduction Version

2.12.0

Relevant Info

No response

Regression?

2.11.1

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@COV-GIS COV-GIS added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 29, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 29, 2024
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Aug 29, 2024
@geospatialem
Copy link
Member

Possibly related to #9957.

@geospatialem geospatialem added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Aug 29, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Aug 29, 2024
@geospatialem geospatialem added estimate - 2 Small fix or update, may require updates to tests. estimate - 3 A day or two of work, likely requires updates to tests. and removed estimate - 2 Small fix or update, may require updates to tests. labels Aug 29, 2024
@geospatialem
Copy link
Member

After closer inspection it appears the regression is from #10147 from the following lines: 3c4775c#diff-98ccabacd6112ddd54974f877b97ee4e4db45ca390ab1326c026a0f70b5d0dd4.

We should explore screenshot testing that supports multiple snapshots after timeline to ensure the component spinning is performing as-expected.

@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 29, 2024
@Elijbet Elijbet mentioned this issue Aug 29, 2024
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 29, 2024
Elijbet added a commit that referenced this issue Sep 3, 2024
@Elijbet
fix(loader): restore animation (#10184)
1ae7cc1 
**Related Issue:** #10182

## Summary
While the new lint rule catches non-kebab-cased names at `@function`
definition, it does not catch wrong casing when applied. This fixes
missed applications.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet Sep 3, 2024
@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Sep 3, 2024
@geospatialem geospatialem added the 4 - verified Issues that have been released and confirmed resolved. label Sep 3, 2024
@geospatialem
Copy link
Member

Verified in 2.13.0-next.5 with https://codepen.io/geospatialem/pen/poXQJWz

benelan pushed a commit that referenced this issue Sep 4, 2024
@Elijbet @benelan
fix(loader): restore animation (#10184)
fcb2191 
**Related Issue:** #10182

## Summary
While the new lint rule catches non-kebab-cased names at `@function`
definition, it does not catch wrong casing when applied. This fixes
missed applications.
benelan pushed a commit that referenced this issue Sep 4, 2024
@Elijbet @benelan
fix(loader): restore animation (#10184)
52081ca 
**Related Issue:** #10182

## Summary
While the new lint rule catches non-kebab-cased names at `@function`
definition, it does not catch wrong casing when applied. This fixes
missed applications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2.12.1 patch
Development

No branches or pull requests
4 participants
@geospatialem @COV-GIS @Elijbet @DitwanP