Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputTimePicker/InputTimeZone unstable test #10227

Open
driskull opened this issue Sep 5, 2024 · 5 comments
Open

InputTimePicker/InputTimeZone unstable test #10227

driskull opened this issue Sep 5, 2024 · 5 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. testing Issues related to automated or manual testing.

Comments

@driskull
Copy link
Member

driskull commented Sep 5, 2024

Priority impact

p - high

Test type

unstable

Which Component(s)

input-time-picker, input-time-zone

Unstable Tests

openClose("calcite-input-time-picker", { initialToggleValue: true });

Test error, if applicable

Summary of all failing tests
@esri/calcite-components:test: FAIL src/components/input-time-picker/input-time-picker.e2e.ts (51.699 s)
@esri/calcite-components:test: ● calcite-input-time-picker › openClose › initially open › emits on initialization with animations enabled
@esri/calcite-components:test:
@esri/calcite-components:test: expect(received).toBeGreaterThan(expected)
@esri/calcite-components:test:
@esri/calcite-components:test: Expected: > 100
@esri/calcite-components:test: Received: 1
@esri/calcite-components:test:
@esri/calcite-components:test: 205 | const matcherName = animationsEnabled ? "toBeGreaterThan" : ("toBeLessThanOrEqual" as const);
@esri/calcite-components:test: 206 |
@esri/calcite-components:test: > 207 | expect(delayBetweenBeforeOpenAndOpen)matcherName;
@esri/calcite-components:test: | ^
@esri/calcite-components:test: 208 | expect(delayBetweenBeforeCloseAndClose)matcherName;
@esri/calcite-components:test: 209 | }
@esri/calcite-components:test: 210 |
@esri/calcite-components:test:
@esri/calcite-components:test: at testOpenCloseEvents (src/tests/commonTests/openClose.ts:207:55)
@esri/calcite-components:test: at Object. (src/tests/commonTests/openClose.ts:218:7)
@esri/calcite-components:test:
@esri/calcite-components:test:

Same test failure for input-time-zone.

PR skipped, if applicable

#10226, #10228

Additional Info

No response

@driskull driskull added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Sep 5, 2024
@jcfranco jcfranco self-assigned this Sep 5, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 5, 2024
@jcfranco
Copy link
Member

jcfranco commented Sep 5, 2024

Noticed a similar failure locally with #10228. Will update the issue title/description to investigate both under this issue.

@jcfranco jcfranco changed the title InputTimePicker unstable test InputTimePicker/InputTimeZone unstable test Sep 5, 2024
jcfranco added a commit that referenced this issue Sep 9, 2024
**Related Issue:** #10227

## Summary

Re-skip unstable test (see #10226).

Unfortunately, #10228
didn't stabilize this test.
benelan pushed a commit that referenced this issue Sep 9, 2024
**Related Issue:** #10227

## Summary

Re-skip unstable test (see #10226).

Unfortunately, #10228
didn't stabilize this test.
benelan pushed a commit that referenced this issue Sep 9, 2024
**Related Issue:** #10227

## Summary

Re-skip unstable test (see #10226).

Unfortunately, #10228
didn't stabilize this test.
@jcfranco
Copy link
Member

#10228 addressed the input-time-zone failure. Will look into the input-time-picker one.

@jcfranco
Copy link
Member

#10310 might help here.

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Oct 31, 2024
Copy link
Contributor

Issue #10310 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

@github-actions github-actions bot removed the blocked This issue is blocked by another issue. label Nov 26, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Nov 26, 2024
@geospatialem
Copy link
Member

Spike needed to determine if the migration to Lit mitigates the failure.

@DitwanP DitwanP added this to the 2025-07-29 - 3.3.0 Jul Release milestone Dec 2, 2024
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. testing Issues related to automated or manual testing.
Projects
None yet
Development

No branches or pull requests

4 participants