fix(panel, flow-item): hide focus-outline when scrolling via mouse to align with browsers #10242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… align with browsers * tidy up focus styles
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
alisonailea
approved these changes
Sep 6, 2024
jcfranco
deleted the
jcfranco/10238-hide-focus-ring-on-clicked-panel-scroller
branch
benelan
pushed a commit
that referenced
this pull request
Sep 9, 2024
… align with browsers (#10242) **Related Issue:** #10238 ## Summary Fixes a regression caused by #10141 where clicks on scrollers would show the focus outline. ### Notes * this behavior aligns with Chrome/Firefox's latest default focus on scrolling content behavior * `:focus-visible` [isn’t supported in Safari 15.0 - 15.3](https://caniuse.com/?search=focus-visible), but given Safari 18 is expected this year, this is a minor visual inconsistency for unsupported versions. * cleans up focus styles that should have been updated by #10141. * no tests were added as we currently don't cover interactive focus-related styling
benelan
pushed a commit
that referenced
this pull request
Sep 9, 2024
… align with browsers (#10242) **Related Issue:** #10238 ## Summary Fixes a regression caused by #10141 where clicks on scrollers would show the focus outline. ### Notes * this behavior aligns with Chrome/Firefox's latest default focus on scrolling content behavior * `:focus-visible` [isn’t supported in Safari 15.0 - 15.3](https://caniuse.com/?search=focus-visible), but given Safari 18 is expected this year, this is a minor visual inconsistency for unsupported versions. * cleans up focus styles that should have been updated by #10141. * no tests were added as we currently don't cover interactive focus-related styling
Merged
benelan
added a commit
that referenced
this pull request
Sep 9, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.12.2</summary> ## [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.1...@esri/calcite-components@2.12.2) (2024-09-09) ### Bug Fixes * **input-time-zone:** Ensure `beforeOpen`/`open` and `beforeClose`/`close` events emit properly ([#10228](#10228)) ([71423cb](71423cb)) * **panel, flow-item:** Hide focus-outline when scrolling via mouse to align with browsers ([#10242](#10242)) ([7a8cb72](7a8cb72)) * **shell:** Fix z-index of shell-panels ([#10224](#10224)) ([36d51b6](36d51b6)) </details> <details><summary>@esri/calcite-components-angular: 2.12.2</summary> ## [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.1...@esri/calcite-components-angular@2.12.2) (2024-09-09) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.12.1 to 2.12.2 </details> <details><summary>@esri/calcite-components-react: 2.12.2</summary> ## [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.1...@esri/calcite-components-react@2.12.2) (2024-09-09) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.12.1 to 2.12.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
added a commit
that referenced
this pull request
Sep 9, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.12.2</summary> [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.1...@esri/calcite-components@2.12.2) (2024-09-09) * **input-time-zone:** Ensure `beforeOpen`/`open` and `beforeClose`/`close` events emit properly ([#10228](#10228)) ([71423cb](71423cb)) * **panel, flow-item:** Hide focus-outline when scrolling via mouse to align with browsers ([#10242](#10242)) ([7a8cb72](7a8cb72)) * **shell:** Fix z-index of shell-panels ([#10224](#10224)) ([36d51b6](36d51b6)) </details> <details><summary>@esri/calcite-components-angular: 2.12.2</summary> [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.1...@esri/calcite-components-angular@2.12.2) (2024-09-09) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.12.1 to 2.12.2 </details> <details><summary>@esri/calcite-components-react: 2.12.2</summary> [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.1...@esri/calcite-components-react@2.12.2) (2024-09-09) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.12.1 to 2.12.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
added a commit
that referenced
this pull request
Sep 9, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.12.2</summary> [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.1...@esri/calcite-components@2.12.2) (2024-09-09) * **input-time-zone:** Ensure `beforeOpen`/`open` and `beforeClose`/`close` events emit properly ([#10228](#10228)) ([71423cb](71423cb)) * **panel, flow-item:** Hide focus-outline when scrolling via mouse to align with browsers ([#10242](#10242)) ([7a8cb72](7a8cb72)) * **shell:** Fix z-index of shell-panels ([#10224](#10224)) ([36d51b6](36d51b6)) </details> <details><summary>@esri/calcite-components-angular: 2.12.2</summary> [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.1...@esri/calcite-components-angular@2.12.2) (2024-09-09) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.12.1 to 2.12.2 </details> <details><summary>@esri/calcite-components-react: 2.12.2</summary> [2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.1...@esri/calcite-components-react@2.12.2) (2024-09-09) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.12.1 to 2.12.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10238
Summary
Fixes a regression caused by #10141 where clicks on scrollers would show the focus outline.
Notes
:focus-visibleisn’t supported in Safari 15.0 - 15.3, but given Safari 18 is expected this year, this is a minor visual inconsistency for unsupported versions.