Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate component framework to Lit #10310

Closed
jcfranco opened this issue Sep 13, 2024 · 2 comments
Closed

Migrate component framework to Lit #10310

jcfranco opened this issue Sep 13, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality tooling Issues relating to build system fixes or improvements.
Milestone
2024-11-26 - 3.0....

Comments

@jcfranco
Copy link
Member

jcfranco commented Sep 13, 2024 •
edited by DitwanP
Loading

Priority impact

p - high

Summary

Migrating to Lit will enable us to leverage key features that will streamline development and improve our overall workflow.

Blocked issues: #8249, #220, #8307, #9057, #9090, #10038, #10237, #10263, #9089, #7631, #9494, #10399, #10423, #10422, #10376, #991, #10619, #10227, #9260

Desired Outcome

Components are fully Lit-based.

Resources

No response

Related

#10356
#10352
#10344
#8073 (comment) (might address potential bug)
@jcfranco jcfranco added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 13, 2024
@github-actions github-actions bot added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Sep 13, 2024
@jcfranco jcfranco mentioned this issue Sep 13, 2024
Closed
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Sep 13, 2024
@geospatialem geospatialem added estimate - 8 Requires input from team, consider smaller steps. and removed needs triage Planning workflow - pending design/dev review. labels Sep 13, 2024
@geospatialem geospatialem mentioned this issue Sep 13, 2024
Closed
6 tasks
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. 2 - in development Issues that are actively being worked on. labels Sep 14, 2024
@jcfranco jcfranco self-assigned this Sep 14, 2024
@jcfranco jcfranco mentioned this issue Sep 15, 2024
Closed
@geospatialem geospatialem mentioned this issue Sep 16, 2024
Open
6 tasks
This was referenced Sep 16, 2024
Open
Open
Closed
This was referenced Sep 25, 2024
Closed
Closed
Closed
This was referenced Sep 26, 2024
Closed
Closed
Open
@jcfranco jcfranco mentioned this issue Sep 26, 2024
Open
5 tasks
@geospatialem geospatialem mentioned this issue Sep 26, 2024
Open
5 tasks
@jcfranco jcfranco mentioned this issue Nov 4, 2024
Merged
jcfranco added a commit that referenced this issue Nov 4, 2024
@jcfranco
refactor!: remove deprecated ban-props-on-host, `enforce-ref-last-p…
8564dcf 
…rop`, `require-event-emitter-type` rules

BREAKING CHANGES: The following deprecated rules from `@esri/eslint-plugin-calcite-components` have been removed due to changes introduced in #10310:

* `ban-props-on-host`
* `enforce-ref-last-prop`
* `require-event-emitter-type`

Developers should either remain on the current version or remove these rules from their ESLint configuration to avoid potential issues.
This was referenced Nov 4, 2024
Merged
Merged
jcfranco added a commit that referenced this issue Nov 4, 2024
@jcfranco
refactor!: remove deprecated ban-props-on-host, `enforce-ref-last-p…
c399c10 
…rop`, `require-event-emitter-type` rules (#10679)

**Related Issue:** #10398

## Summary

Remove deprecated custom ESLint rules.

BREAKING CHANGE: The following deprecated rules from
`@esri/eslint-plugin-calcite-components` have been removed due to
changes introduced in #10310:

* `ban-props-on-host`
* `enforce-ref-last-prop`
* `require-event-emitter-type`

Developers should either remain on the current version or remove these
rules from their ESLint configuration to avoid potential issues.
@jcfranco jcfranco mentioned this issue Nov 5, 2024
Closed
This was referenced Nov 13, 2024
Closed
Open
jcfranco added a commit that referenced this issue Nov 15, 2024
@maxpatiiuk @jcfranco
@benelan @calcite-admin @renovate
refactor!: migrate to Lumina (#10482)
b2c9762 
**Related Issue:** #10310, #10481, #10399, #10405, #10491, #10434,
#10495, #9260

## Noteworthy changes

* components are now Lit-based
* removed `@storybook/test` and `@storybook/addon-interactions` as these
were not being actively used
* React deps bumped to v18
* Added default `scale` value to:
  * `action-bar`
  * `action-group`
  * `action-menu`
  * `action-pad`
* Path of extras will change to the following:
* `/dist/extras/vscode-data.json` ➡️
`/dist/docs/vscode.html-custom-data.json`
* backwards-compatible version is preserved to not break Intellisense
[described in the
doc](https://developers.arcgis.com/calcite-design-system/resources/frameworks/#visual-studio-intellisense)
	* `/dist/extras/docs-json.json` ➡️ `/dist/docs/docs.json` (internal)
* `/dist/extras/translations-json.json` ➡️
`/dist/docs/translations.json` (internal)
	* `/dist/extras/docs-json.d.ts` ❌ (removed, internal)

BREAKING CHANGE: 

* for a consistent development experience, components now convert `null`
to `undefined`, so developers will need to update code with strict null
checks
* removed the following `@esri/eslint-plugin-calcite-components` rules
as they are no longer valid:
	* `ban-props-on-host`
	* `enforce-ref-last-prop`
	* `require-event-emitter-type`

---------

Co-authored-by: JC Franco <jfranco@esri.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jcfranco jcfranco added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Nov 15, 2024
@github-actions github-actions bot removed the 2 - in development Issues that are actively being worked on. label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 15, 2024

Verified 🔥

@DitwanP DitwanP closed this as completed Nov 15, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 18, 2024
This was referenced Nov 21, 2024
Closed
Closed
Open
Closed
Closed
@DitwanP DitwanP reopened this Nov 26, 2024
@DitwanP DitwanP closed this as completed Nov 26, 2024
@github-actions github-actions bot mentioned this issue Nov 26, 2024
Closed
@jcfranco jcfranco mentioned this issue Dec 3, 2024
Merged
jcfranco added a commit that referenced this issue Dec 4, 2024
@jcfranco
fix(combobox): fix sporadic change event emitted on initialization (#…
e84ed58 
…10952)

**Related Issue:** #10731

## Summary

Tweaks initialization logic to prevent extraneous change event that
happened after #10310.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP