Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell-center-row] slotted action bar position change will not update shell center row #10468

Closed
2 of 6 tasks
driskull opened this issue Oct 1, 2024 · 2 comments
Closed
2 of 6 tasks

[shell-center-row] slotted action bar position change will not update shell center row #10468

driskull opened this issue Oct 1, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive

Comments

@driskull
Copy link
Member

driskull commented Oct 1, 2024

Check existing issues

Actual Behavior

If action-bar position changes after being slotted, the ordering of elements will be incorrect.

Expected Behavior

If action-bar position changes after being slotted, the ordering will be correct.

Reproduction Sample

https://codepen.io/driskull/pen/oNKbWzR?editors=1010

Reproduction Steps

  1. open codepen
  2. wait 500ms
  3. notice that actionBar position doesn't change

Reproduction Version

2.13.0

Relevant Info

#10451 (comment)

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 1, 2024
@driskull driskull mentioned this issue Oct 1, 2024
Merged
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Oct 1, 2024
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Installed and assigned for verification.

@geospatialem geospatialem added the estimate - 3 A day or two of work, likely requires updates to tests. label Nov 6, 2024
@geospatialem geospatialem removed this from the 2024-10-29 - Oct Milestone milestone Nov 6, 2024
@geospatialem
Copy link
Member

It looks like the above was also mentioned in a PR for inclusion. During yesterday's triage session we discussed closing the above since shell-center-row is now deprecated. Closing the above out.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP