Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell + Shell Panel: Erroneous component deprecations communicated to console #10563

Closed
4 of 8 tasks
geospatialem opened this issue Oct 19, 2024 · 2 comments
Closed
4 of 8 tasks

Shell + Shell Panel: Erroneous component deprecations communicated to console #10563

geospatialem opened this issue Oct 19, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2.13.2 patch

Comments

@geospatialem
Copy link
Member

geospatialem commented Oct 19, 2024 •
edited
Loading

Check existing issues

Actual Behavior

When using the shell or shell-panel components a deprecation message via Logger is added to the console as a result of component bundling

Expected Behavior

  • No logger message when using shell or shell-panel.
  • Logger message for shell-center-row

Reproduction Sample

https://codepen.io/geospatialem/pen/KKOqaBK

Reproduction Steps

  1. Open the sample
  2. Open the console
  3. Observe the logger message for shell

Reproduction Version

2.13.1

Relevant Info

Spotted by @ellenupp via #10506 (comment).

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

We should address via a patch since logger will pick this up for shell and shell-panel instances

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. labels Oct 19, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Oct 19, 2024
@geospatialem geospatialem mentioned this issue Oct 19, 2024
Merged
@geospatialem geospatialem added this to the 2.13.2 patch milestone Oct 19, 2024
jcfranco added a commit that referenced this issue Oct 21, 2024
@jcfranco
fix(shell-center-row): ensure deprecation warning doesn’t show when u…
a456c22 
…sing standalone `shell` or `shell-panel` (#10561)

**Related Issue:** #10563

## Summary

Moves deprecation warnings to show when `shell-center-row` is added to
the DOM and initially loaded.

This warning was being shown due to
[bundling](https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/stencil.config.ts#L76).
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 21, 2024
@geospatialem
Copy link
Member Author

Verified with https://codepen.io/geospatialem/pen/KKOqaBK in 2.14.0-next.15 with shell and shell-panel. The logger message is communicated to shell-center-row still and will be part of the upcoming 2.13.2 patch. 🎉

benelan pushed a commit that referenced this issue Oct 23, 2024
@jcfranco @benelan
fix(shell-center-row): ensure deprecation warning doesn’t show when u…
09d74ae 
…sing standalone `shell` or `shell-panel` (#10561)

**Related Issue:** #10563

## Summary

Moves deprecation warnings to show when `shell-center-row` is added to
the DOM and initially loaded.

This warning was being shown due to
[bundling](https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/stencil.config.ts#L76).
@jcfranco jcfranco mentioned this issue Oct 25, 2024
Merged
jcfranco added a commit that referenced this issue Oct 25, 2024
@jcfranco
refactor: move deprecation warnings to componentWillLoad to avoid inc…
d256c99 
…orrect messaging due to bundling (#10612)

**Related Issue:** N/A

## Summary

This prevents issues similar to #10563.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2.13.2 patch
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP