Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stepper] - Remove goTo... methods from Stepper #6134

Closed
macandcheese opened this issue Dec 20, 2022 · 3 comments
Closed

[Stepper] - Remove goTo... methods from Stepper #6134

macandcheese opened this issue Dec 20, 2022 · 3 comments
Labels
0 - new New issues that need assignment. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked. resolution: refine For issues we support, but additional details are needed prior to dev work.
Milestone
Freezer

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Dec 20, 2022 •
edited
Loading

Description

This pattern of using methods (goToStep(),endStep(),startStep(),nextStep(),prevStep()) to navigate steps is an outdated pattern - we should refactor the component to no longer use / accept these methods (internally as well as externally). The public story should be to assign / adjust the selected property as needed on the desired stepper-item.

Proposed Advantages

Bring the stepper and stepper-item component in line with more recent patterns.

Which Component

Stepper / Stepper Item

Relevant Info

No response
@macandcheese macandcheese added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 20, 2022
@geospatialem geospatialem added this to the 2023 May Priorities milestone Dec 21, 2022
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 21, 2022
@jcfranco
Copy link
Member

I'm not sure I agree with this request. What you're proposing means that the user would need to store references to all items, or query the DOM for them, and manage selection as the user interacts with the app. Is this correct?

@macandcheese
Copy link
Contributor Author

This issue was opened as the result of a Teams discussion or issue follow up (can’t remember), where it was noted this was kind of a one off pattern.

If it’s fine to keep them around we can disregard this and maybe add a guideline around it.

@jcfranco jcfranco added p - low Issue is non core or affecting less that 10% of people using the library resolution: refine For issues we support, but additional details are needed prior to dev work. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. labels Apr 28, 2023
@jcfranco jcfranco mentioned this issue Apr 19, 2024
Merged
@macandcheese
Copy link
Contributor Author

Closing based on discussion - original issue was brought up in Teams but we are choosing not to pursue at this time.

@macandcheese macandcheese closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@jcfranco jcfranco mentioned this issue May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked. resolution: refine For issues we support, but additional details are needed prior to dev work.
Projects
None yet
Milestone
Freezer
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @macandcheese @geospatialem