-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Responsive layout #6687
Comments
Update from team discussion today: Additional action items for the team: Look at how this could also be used on desktop size viewports. |
Added another section with final revisions! Figma link here: https://www.figma.com/file/zBGnAOEOxqKGocUjqiYbed/Responsive-Layout?node-id=13257%3A304540&t=sQkUqpbjmja9kXmQ-1 Here are the screenshots of the three options for screen widths ranging from 320px-479px. Full designs in the Figma link above :) |
Some feedback - I like I would be interested to see a combination of the location of the Not a huge fan of the caret or the blue color, I wonder if we can look at some other styles for that button? Maybe treating the "100" differently than the "of 199" like the |
I'm not sure the The @SkyeSeitz @rmstinson @geospatialem can you comment on the above? |
I think it would also be good if we have an option to turn off the pagination menu. What do you think? |
Agreed - I think that complex of an interaction is outside the scope of a Calcite Components pagination component. I'd expect Pagination to be limited to (at the most), page selection, "page size / items per page" selection, and direct page selection. Launching a "rich detail" list of Pagination options like in the above widget is valid UI, but I think it's something you could build separately, as the content could be drastically different depending on need. Like @driskull mentioned, I think that particular UI could probably use a dropdown, having an entire Panel header UI there in a List seems kind of heavy. |
Do we want to kick this issue back to design? its slotted for the current responsive milestone. cc @brittneytewks |
Will defer to @SkyeSeitz but I think the plan is to add additional display modes and the responsive behavior will be to collapse the number of visible "page steps" as container size shrinks. I don't think this component needs to consider having UI of "launch a list or dropdown or other component to have a rich selection". That IMO is not really part of pagination. Really those are more like Carousel since only one item is being displayed at a time. |
Maybe a user could just slot in something that displays at the xs size? Then they could add a menu/button/whatever? |
Yeah. I think at any size really, just place that adjacent to the pagination, pagination’s responsive adjustment could just be reduce number of pages shown as needed. The other view modes are good to have as an option at any viewport. |
Thanks for the thoughts above, folks. I am in agreement the first question is regarding scope of what we consider responsive- I would consider the following behavior a responsive Calcite Pagination component. responsive-pagination-mockup.mov |
Updated Figma link for responsive feature. Sounds like non-responsive features that are valuable at any viewport size, such as items per page or additional display modes, can be logged separate from this issue 👍🏽 |
**Related Issue:** #6687 ## Summary - Makes pagination responsive - Uses resize observer - Makes ellipsis and page styles equivalent - Refactor page rendering logic to count ellipsis as well as pages. Next/previous buttons are not counted because they are always present. - Exports Breakpoints interface from helper - Modifies some e2e tests - Adds screenshot tests These are the proposed amount of items per breakpoint. (item numbers are pages + ellipsis) ```ts const maxItemBreakpoints = { large: 11, medium: 9, small: 7, xsmall: 5, }; ```
Installed and assigned for verification. |
Description
Responsiveness across Calcite Design System, focused on web (traditionally desktop sized web browser), tablet, phone screen sizes, and large monitors.
Acceptance Criteria
476px
768px
1152px
1440px
Relevant Info
Part of epic #6670
Which Component
pagination
Example Use Case
No response
Priority impact
p4 - not time sensitive
Esri team
Calcite (design)
The text was updated successfully, but these errors were encountered: