Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] Consistent width-scale , height-scale values across components #7616

Open
2 of 3 tasks
macandcheese opened this issue Aug 29, 2023 · 1 comment
Open
2 of 3 tasks

[Design] Consistent width-scale , height-scale values across components #7616

macandcheese opened this issue Aug 29, 2023 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - md Medium design effort; 5-10 days of design work estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
Design Backlog

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Aug 29, 2023 •
edited
Loading

Check existing issues

Description

Components like Shell Panel, Sheet, and Modal have width-scale properties - we should consolidate these into a shared set of widths if possible, and reference those. Same for height-scale.

Dropdown also has width - but that property might not be needed anymore - just have it set by the scale, or longest text string.

Acceptance Criteria

A shared set of default width values is available for components that use width-scale and height-scale

Relevant Info

cc @ashetland @SkyeSeitz

Which Component

Shell Panel, Sheet, Modal, Dropdown (?)

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 29, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. Calcite (design) Issues logged by Calcite designers. labels Aug 29, 2023
@macandcheese macandcheese mentioned this issue Aug 29, 2023
Merged
@macandcheese macandcheese added the p - low Issue is non core or affecting less that 10% of people using the library label Aug 29, 2023
@macandcheese macandcheese mentioned this issue Aug 29, 2023
Closed
4 tasks
macandcheese added a commit that referenced this issue Aug 30, 2023
@macandcheese
feat(sheet): Update default widths (#7617)
47d2c0b 
Updates the default Sheet css variables. Users can of course override
any of these as needed but these work better for most expected Sheet use
cases.

## Summary
Opened this to create a set of shared widths for other components:
#7616
@geospatialem geospatialem added design Issues that need design consultation prior to development. estimate - 8 Requires input from team, consider smaller steps. labels Jun 25, 2024
@geospatialem
Copy link
Member

For design expertise - to confirm components prior to assigning to a future dev milestone.

@DitwanP DitwanP added estimate - design - sm Small design effort; 1-4 days of design work and removed needs triage Planning workflow - pending design/dev review. labels Jul 11, 2024
@DitwanP DitwanP added this to the Design Backlog milestone Jul 11, 2024
@DitwanP DitwanP added estimate - design - md Medium design effort; 5-10 days of design work and removed estimate - design - sm Small design effort; 1-4 days of design work labels Jul 11, 2024
@Elijbet Elijbet mentioned this issue Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - md Medium design effort; 5-10 days of design work estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
Design Backlog
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP