Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calcite-block-section does not account for switch space when rendering text #7698

Closed
2 of 3 tasks
ian13262 opened this issue Sep 7, 2023 · 5 comments
Closed
2 of 3 tasks

Calcite-block-section does not account for switch space when rendering text #7698

ian13262 opened this issue Sep 7, 2023 · 5 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 November Pri...

Comments

@ian13262
Copy link

ian13262 commented Sep 7, 2023 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

When rendering text, calcite-block-sections do not account for the space taken up by a switch. Text should wrap on an additional line in this situation.
image

image

Expected Behavior

Text should stop before the switch and continue onto the next line if necessary.

Reproduction Sample

https://codepen.io/iyouth66/pen/gOZgomO?editors=1100

Reproduction Steps

(see codepen)

Reproduction Version

1.7.0

Relevant Info

N/A

Regression?

1.6.1

Priority impact

p2 - want for current milestone

Impact

Smart mapping currently suffers from this issue:
image

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Online
@ian13262 ian13262 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 7, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Online Issues logged by ArcGIS Online team members. labels Sep 7, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library and removed needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library labels Sep 18, 2023
@geospatialem
Copy link
Member

Investigate if using the stack component could mitigate the above.

@AdelheidF AdelheidF removed the p - low Issue is non core or affecting less that 10% of people using the library label Oct 27, 2023
@AdelheidF
Copy link

Could this be get fixed before January? It's all over the place ...

image

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that. labels Oct 30, 2023
@geospatialem
Copy link
Member

@AdelheidF @ian13262 It looks like this is a regression between 1.6.1 and 1.7.0 as a result of accessibility improvements to the component - added context to the issue summary above.

More context:

Added a regression label and medium priority level, and hope to tackle before the close of 2023 with other priority issues.

@geospatialem geospatialem added this to the 2023 November Priorities milestone Oct 30, 2023
@anveshmekala anveshmekala self-assigned this Oct 31, 2023
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 31, 2023
@anveshmekala anveshmekala mentioned this issue Nov 1, 2023
Merged
anveshmekala added a commit that referenced this issue Nov 3, 2023
@anveshmekala
fix(block-section): wraps long text over to a new line when toggle sw…
3f90780 
…itch is displayed (#8101)

**Related Issue:** #7698 

## Summary

Wraps long text to a new line when `toggle-display='switch'`
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 3, 2023
@github-actions github-actions bot assigned geospatialem and unassigned anveshmekala Nov 3, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Installed and assigned for verification.

@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Nov 16, 2023
@geospatialem geospatialem added the 4 - verified Issues that have been released and confirmed resolved. label Nov 16, 2023
@geospatialem
Copy link
Member

Verified in 1.11.0-next.3:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
4 participants
@geospatialem @AdelheidF @anveshmekala @ian13262