Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-button, when using a link and setting disabled to true, the anchor tag gets a disabled property #8140

Closed
2 of 5 tasks
driskull opened this issue Nov 7, 2023 · 2 comments
Closed
2 of 5 tasks

calcite-button, when using a link and setting disabled to true, the anchor tag gets a disabled property #8140

driskull opened this issue Nov 7, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 December Pri...

Comments

@driskull
Copy link
Member

driskull commented Nov 7, 2023

Check existing issues

Actual Behavior

The anchor tag in the shadow DOM gets a disabled property set when it shouldn't

Expected Behavior

aria-disabled={childElType === "a" && (this.disabled || this.loading)}
disabled={childElType === "button" && (this.disabled || this.loading)}

Reproduction Sample

https://codepen.io/driskull/pen/eYxvYMM

Reproduction Steps

  1. Open the codepen
  2. Check inside the shadowDom
  3. The anchor link has a disabled property
  4. disabled is not a valid property on an anchor link.

Reproduction Version

1.10

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

A11y

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 7, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 7, 2023
@geospatialem geospatialem added good first issue Issues that can be worked on by contributors new to calcite-components. p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Nov 27, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 27, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Nov 27, 2023
@geospatialem geospatialem mentioned this issue Nov 27, 2023
Open
5 tasks
driskull added a commit that referenced this issue Nov 28, 2023
@driskull
fix(button): Sets aria-disabled instead of disabled on internal ancho…
b60728c 
…r element. #8140
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 28, 2023
@driskull driskull mentioned this issue Nov 28, 2023
Merged
driskull added a commit that referenced this issue Nov 28, 2023
@driskull
fix(button): Sets aria-disabled instead of disabled on internal ancho…
0926eb6 
…r element (#8270)

**Related Issue:** #8140

## Summary

- Sets aria-disabled instead of disabled on internal anchor element
- Adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 29, 2023

Verified locally on Main

@DitwanP DitwanP closed this as completed Nov 29, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP