Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure toAriaBoolean is used in rendering #8976

Open
1 of 5 tasks
jcfranco opened this issue Mar 20, 2024 · 3 comments
Open
1 of 5 tasks

Ensure toAriaBoolean is used in rendering #8976

jcfranco opened this issue Mar 20, 2024 · 3 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@jcfranco
Copy link
Member

Description

Stems from #8962 (comment).

Not sure if this is related to the issue, but this, and similar lines, should be using toAriaBoolean (see example). In its current form, it's setting a boolean on the attribute instead of "true" or "false".

Proposed Advantages

ARIA-related boolean attributes need to be explicitly set to "true"/"false" to be interpreted correctly.

Which Component

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 20, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Mar 20, 2024
@driskull
Copy link
Member

driskull commented Mar 21, 2024

This is one downside of a tiny JSX library. I wonder if we could add an eslint rule for this or open an enhancement for Stencil?

If stencil did at something it would have to probably add all aria like ariaHidden={true}

@jcfranco
Copy link
Member Author

I like the idea of adding a custom ESLint rule for this. cc @Elijbet

@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@jcfranco
Copy link
Member Author

#10310 might affect how this is authored and other custom rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

No branches or pull requests

3 participants