Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel & Flow Item] Add "content-top" slot #8980

Closed
2 of 6 tasks
geospatialem opened this issue Mar 21, 2024 · 10 comments
Closed
2 of 6 tasks

[Panel & Flow Item] Add "content-top" slot #8980

geospatialem opened this issue Mar 21, 2024 · 10 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2024-05-28 - May ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Mar 21, 2024 •
edited by SkyeSeitz
Loading

Check existing issues

Description

Add a new slot to the panel and flow-item components - "content-top" below the action-bar slot so we can render in a new Dialog component using the "sticky" functionality currently provided in the Modal component.

Acceptance Criteria

  1. Slot should be sticky as it is Modal
  2. Slot should come with overridable padding
  3. The following css var should be added to match Modal's current overrides:
    --calcite-panel-content-top-padding: Specifies the padding of the component's content-top slot

Relevant Info

A dependency needed for the Dialog + Modal component effort in #7886
See Figma file for specs
image

Which Component

panel
flow-item

Example Use Case

No response

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 21, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Mar 21, 2024
@geospatialem geospatialem mentioned this issue Mar 21, 2024
Closed
9 tasks
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Mar 21, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 15, 2024
@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Apr 25, 2024
@SkyeSeitz SkyeSeitz removed their assignment Apr 25, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@SkyeSeitz SkyeSeitz changed the title [Panel] Add "content-top" slot, deprecate "action-bar" slot [Panel] Add "content-top" slot Apr 25, 2024
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 25, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Apr 25, 2024
@Elijbet Elijbet self-assigned this May 7, 2024
@Elijbet Elijbet added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels May 7, 2024
@Elijbet Elijbet mentioned this issue May 9, 2024
Merged
Elijbet added a commit that referenced this issue May 10, 2024
@Elijbet
feat(panel): add content-top slot (#9293)
df8d71c 
**Related Issue:** #8980

## Summary
Add a new `content-top` slot to the `panel` component.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 13, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@driskull
Copy link
Member

Should we add these slots to flow-item as well?

@jcfranco
Copy link
Member

Good question. I think it'd be good for consistency, but I'll defer to @SkyeSeitz and @ashetland.

@SkyeSeitz
Copy link

Would Flow Item ever be used instead of Panel in Dialog's modal mode?

@driskull
Copy link
Member

I could see that

@SkyeSeitz
Copy link

I am ok with adding this and related enhancements in #7886 to Flow Item. Thanks for bringing it up, @driskull.

@SkyeSeitz SkyeSeitz changed the title [Panel] Add "content-top" slot [Panel & Flow Item] Add "content-top" slot May 13, 2024
@DitwanP
Copy link
Contributor

DitwanP commented May 13, 2024 •
edited
Loading

Moving back to in development to include changes to flow-item as well.

@DitwanP DitwanP added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 13, 2024
@DitwanP DitwanP assigned Elijbet and unassigned geospatialem and DitwanP May 13, 2024
@Elijbet Elijbet mentioned this issue May 15, 2024
Merged
Elijbet added a commit that referenced this issue May 15, 2024
@Elijbet
feat(flow-item): add content-top slot (#9344)
e932f3d 
**Related Issue:** #8980

## Summary
Add a new `content-top` slot to the `flow-item` component.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 15, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented May 21, 2024

🍡 Verified on 2.9.0-next.18

@DitwanP DitwanP closed this as completed May 21, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
6 participants
@jcfranco @driskull @geospatialem @Elijbet @SkyeSeitz @DitwanP