Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alert): add 'queue' property to prioritize the ordering of alerts when opened #10029
feat(alert): add 'queue' property to prioritize the ordering of alerts when opened #10029
Changes from all commits
042e866
12009f5
a6e416d
4479751
ea1f450
82669cc
78ab672
1ea9c1c
207e7cf
3ad4857
24e1a28
3020339
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if this is needed? #9958 fixed some issues that prevented alert (among other components) from honoring
--calcite-duration-factor
(used byskipAnimations
). If you still need to wait for the alert to be open, you could listen for the open event instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is still needed because the queue uses a setTimeout to wait for the animation to end.
calcite-design-system/packages/calcite-components/src/components/alert/alert.tsx
Lines 528 to 531 in 089cecf
I think that above would need to change to pull from the CSS var
--calcite-internal-animation-timing-slow
and convert the string MS value to an integer.Maybe a good follow up issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up issue sounds good. Thanks for checking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#10098
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨🏆✨