Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): allow shell to be slotted inside #10108

Closed
wants to merge 3 commits into from
Closed

fix(dialog): allow shell to be slotted inside #10108

wants to merge 3 commits into from

Conversation

driskull
Copy link
Member

Related Issue: #10095

Summary

  • supports shell being slotted inside dialog content
  • add story screenshot test

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Aug 19, 2024
@driskull driskull marked this pull request as ready for review August 19, 2024 20:42
macandcheese
macandcheese approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 Looks good - maybe in the future we can look at Shell defaulting to position:absolute because it can lead to unexpected displays in other cases as well.

@driskull
Copy link
Member Author

Yeah I was thinking the same thing. Anywhere we want shell slotted would need this kind of fix.

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 19, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 19, 2024
@driskull
Copy link
Member Author

Found an issue where making the content container div display as flex: 1 1 auto would shift the FAB down to the bottom.

Not sure of a way to work around this so I'll close the issue.

This may be better fixed by not making the shell positioned absoutely.

@driskull driskull closed this Aug 19, 2024
@driskull driskull deleted the dris0000/dialog-shell-inside branch August 19, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese approved these changes

@alisonailea alisonailea alisonailea approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driskull @alisonailea @macandcheese