Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(themed): tidy up types #10166

Merged
merged 1 commit into from
Aug 27, 2024
Merged

refactor(themed): tidy up types #10166

merged 1 commit into from
Aug 27, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Aug 27, 2024

Related Issue: N/A

Summary

  • hides internal types
  • makes expectedValue required

* hide internal types
* make `expectedValue` required
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Aug 27, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 27, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit f2391ab into dev Aug 27, 2024
16 checks passed
@jcfranco jcfranco deleted the jcfranco/tidy-up-themed branch August 27, 2024 18:10
@github-actions github-actions bot added this to the 2024-08-27 - Aug Release milestone Aug 27, 2024
benelan added a commit that referenced this pull request Aug 27, 2024
…oating-point-issue

* origin/dev:
  build(deps): update nrwl monorepo to v19.6.2 (#10151)
  docs: update component READMEs (#10103)
  feat(dialog): add resizable and dragEnabled properties (#9804)
  refactor(themed): tidy up types (#10166)
  chore(segmented-control): remove empty and irrelevant `describe` block (#10157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants