refactor(pick-list, pick-list-group, pick-list-item, value-list, value-list-group, value-list-item)!: Remove deprecated components.

[aPreciado88]

Related Issues:

#9296
#9297

Summary

Remove the following deprecated components:

• pick-list
• pick-list-group
• pick-list-item
• value-list
• value-list-group
• value-list-item

BREAKING CHANGE: Use the List component instead.

[driskull]

@aPreciado88 since this is a breaking change, it needs the ! in the title and breaking changes notes from here:
https://github.com/Esri/calcite-design-system/blob/dev/CONTRIBUTING.md#commit-message-format

I'm not sure if deprecate() is the right thing here.

deprecate: Documentation only changes for a deprecation 👎

It might be refactor()!: but I don't think our changelog picks up refactors so maybe we should use fix()!:? cc @jcfranco

[aPreciado88]

@driskull I updated the title and description. Thanks for catching that!

[driskull]

Maybe the PR title can be shorted to:

fix(pick-list, pick-list-group, pick-list-item, value-list, value-list-group, value-list-item)!: Remove deprecated components.

And the breaking change description:

BREAKING CHANGE: The list component should be used instead of the following components:

[driskull]

LGTM! Should wait to merge until after the oct release wraps up.

[aPreciado88]

@ashetland @SkyeSeitz Could you please take a look at the chromatic build? It looks like they're false positives, but I want to confirm.

[ashetland]

Yep, just the usual set of false positives. 🍰

[jcfranco]

Can you move the BREAKING CHANGE footer to the end of the description? It needs to be placed at the bottom to adhere to the conventional commits spec:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

[jcfranco]

It might be refactor()!: but I don't think our changelog picks up refactors so maybe we should use fix()!:? cc @jcfranco

refactor is the appropriate type. The breaking changes will be reflected in the changelog (see 2.0.0 changelog and some example PRs).