refactor(responsive): use JS module to create breakpoints lookup object #8051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
pr ready for visual snapshots
github-actions
bot
added
the
refactor
jcfranco
added
pr ready for visual snapshots
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
jcfranco
removed
the
Stale
|
@alisonailea I'm going to proceed with merging, but please LMK if you spot anything and I can address afterwards. |
jcfranco
deleted the
jcfranco/update-responsive-util-to-use-esm-token-exports
branch
benelan
pushed a commit
that referenced
this pull request
Nov 13, 2023
…ct (#8051) **Related Issue:** N/A ## Summary Stems from #8041 (comment). This changes how breakpoints are built and used (`responsive` module): * uses design tokens JS output target to reference breakpoint values * prevents possible disconnect between stylesheet and conditional rendering breakpoint values (only the latter could be overridden via CSS props) * the breakpoints lookup object no longer needs to be obtained asynchronously This also updates and unskips the `responsive` spec test. **Note**: this includes an update to the testing Jest config to apply Stencil's transformer to the design token's headless ESM file as the default one was not transforming properly and leading to `Jest encountered an unexpected token` errors when running the spec test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Stems from #8041 (comment).
This changes how breakpoints are built and used (
responsivemodule):This also updates and unskips the
responsivespec test.Note: this includes an update to the testing Jest config to apply Stencil's transformer to the design token's headless ESM file as the default one was not transforming properly and leading to
Jest encountered an unexpected tokenerrors when running the spec test.