feat(panel): add content-top slot #9293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elijbet
added
the
pr ready for visual snapshots
jcfranco
approved these changes
May 9, 2024
packages/calcite-components/src/components/panel/panel.stories.ts
Outdated
Show resolved
Hide resolved
| <div slot="content-top" id="content-top">Slot for a content-top.</div> | ||
| <div slot="header-content">Header!</div> | ||
| <p>Slotted content!</p> | ||
| <p style="height: 400px">Hello first!</p> |
There was a problem hiding this comment.
Is this the simplest test case or can we simplify by removing these paragraphs with inline styles?
There was a problem hiding this comment.
I can remove inline styles, but paragraphs are there to show the sticky property of content-top when scrolled.
| @@ -440,3 +440,24 @@ export const withNoHeaderBorderBlockEnd_TestOnly = (): string => | |||
| html`<calcite-panel style="--calcite-panel-header-border-block-end:none;" height-scale="s" heading="My Panel" | |||
| >Slotted content!</calcite-panel | |||
| >`; | |||
|
|
|||
| export const contentTopSlot_TestOnly = (): string => html` | |||
| <div style="height: 300px; width: 400px; display: flex"> | |||
There was a problem hiding this comment.
Is this outer element needed for the content-top slot screenshot?
There was a problem hiding this comment.
The outer element is there to restrict the height of the panel so we can see how scrolling of the slotted content affects the header (it should be sticky).
Elijbet
added
pr ready for visual snapshots
Elijbet
added
skip visual snapshots
Merged
geospatialem
modified the milestones:
2024-05-14 - May maintenance release,
2024-05-28 - May Main Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8980
Summary
Add a new
content-topslot to thepanelcomponent.