feat(tooltip): support touch events #9487

driskull · 2024-05-31T22:17:42Z

Related Issue: #9273

Summary

support tap/touch events for tooltip
cleanup
- removed private vars for hoveredTooltip, clickedTooltip to simplify things
add test

github-actions · 2024-06-08T01:46:24Z

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

driskull · 2024-06-20T17:29:54Z

@jcfranco can we do this one for June release?

jcfranco · 2024-06-21T17:45:14Z

packages/calcite-components/src/components/tooltip/TooltipManager.ts

@@ -151,15 +163,15 @@ export default class TooltipManager {
  private addListeners(): void {
    window.addEventListener("keydown", this.keyDownHandler, { capture: true });
    window.addEventListener("pointermove", this.pointerMoveHandler, { capture: true });
-    window.addEventListener("click", this.clickHandler, { capture: true });
+    window.addEventListener("pointerdown", this.pointerDownHandler, { capture: true });


This should stay as a click since it does fire on mobile as well (see example). Also, pointerdown does not share the same context.

Alternatively, this could use pointerdown along with pointerup to prep for #9506.

done! had to remove a test which is no longer appropriate.

driskull · 2024-06-22T00:13:10Z

@jcfranco ready for review again

jcfranco · 2024-06-22T00:22:03Z

It looks like there is a difference in behavior when clicking on an open tooltip (triggered by hovering the reference element):

dev (remains open on tooltip click)

https://www.chromatic.com/component?appId=6266d45509d7eb004aa254fb&csfId=components-tooltip&buildNumber=5123&k=66760245ca218413c410f678-1200px-interactive-true&h=7&b=-1

PR (closes on tooltip click)

https://www.chromatic.com/component?appId=6266d45509d7eb004aa254fb&csfId=components-tooltip&buildNumber=5125&k=667617c3abd71b94f44673b8-1200px-interactive-true&h=3&b=-1

Not sure if it's related to the removed test.

driskull · 2024-06-22T00:26:44Z

@jcfranco I'm not seeing any difference there.

jcfranco · 2024-06-22T00:35:18Z

For posterity, reached out to Matt and a step I missed to include was to hover over the reference element to display the tooltip before clicking. We also spotted an issue where clicking the reference element to toggle the tooltip and then clicking on the tooltip would close for both dev and the PR.

github-actions · 2024-07-02T01:48:39Z

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

driskull · 2024-07-19T23:50:34Z

We also spotted an issue where clicking the reference element to toggle the tooltip and then clicking on the tooltip would close for both dev and the PR.

I think we'll have to ignore this one for now. The issue is that when you are focused on a reference element and then click on a tooltip, the onfocusout is fired which closes the open tooltip before the click can occur.

I think we'll have to address this one as a followup if an issue arrises.

driskull · 2024-07-19T23:53:26Z

@jcfranco ready for review again.

jcfranco

👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈
👈🗯️👈👈👈🗯️👈👈🗯️🗯️👈👈🗯️🗯️🗯️👈👈🗯️🗯️🗯️👈🗯️🗯️🗯️🗯️👈🗯️👈
👈🗯️🗯️👈👈🗯️👈🗯️👈👈🗯️👈👈🗯️👈👈🗯️👈👈👈👈🗯️👈👈👈👈🗯️👈
👈🗯️👈🗯️👈🗯️👈🗯️👈👈🗯️👈👈🗯️👈👈🗯️👈👈👈👈🗯️🗯️🗯️👈👈🗯️👈
👈🗯️👈👈🗯️🗯️👈🗯️👈👈🗯️👈👈🗯️👈👈🗯️👈👈👈👈🗯️👈👈👈👈👈👈
👈🗯️👈👈👈🗯️👈👈🗯️🗯️👈👈🗯️🗯️🗯️👈👈🗯️🗯️🗯️👈🗯️🗯️🗯️🗯️👈🗯️👈
👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈👈

jcfranco · 2024-07-22T17:04:49Z

packages/calcite-components/src/components/tooltip/tooltip.e2e.ts

@@ -371,7 +371,7 @@ describe("calcite-tooltip", () => {
    expect(await tooltip.getProperty("open")).toBe(false);
  });

-  it("should not open tooltip when clicked", async () => {
+  it("should handle touch events", async () => {


This should be mouse or pointer events.

jcfranco · 2024-07-22T17:05:56Z

packages/calcite-components/src/components/tooltip/tooltip.e2e.ts

@@ -388,7 +388,37 @@ describe("calcite-tooltip", () => {

    await page.evaluate(() => {
      const ref = document.getElementById("ref");
-      ref.click();
+      const event1 = new Event("click", {


Just curious, but is there a specific reason why MouseEvent or PointerEvent isn't being used here?

Nope, will update.

jcfranco · 2024-07-22T17:15:57Z

I think we'll have to ignore this one for now. The issue is that when you are focused on a reference element and then click on a tooltip, the onfocusout is fired which closes the open tooltip before the click can occur.
I think we'll have to address this one as a followup if an issue arrises.

@driskull Swap 'ignore' for 'handle separately' and we've got a deal! 😜 For tracking purposes, can you create a separate issue for this?

driskull · 2024-07-22T17:22:02Z

created #9827

…-to-monorepo * origin/dev: feat(combobox, combobox-item): add `metadata` support for filtering (#9819) chore: release next feat(tooltip): support touch events (#9487) build(deps): update storybook monorepo to v8.2.4 (#9815) chore: release next feat(color-picker, color-picker-hex-input): Add input auto commit, blur and auto select enhancements. (#9701) build(deps): update dependency tailwindcss to v3.4.6 (#9814) build(deps): update dependency rollup to v4.18.1 (#9813) build(deps): pin dependencies (#9812)

**Related Issue:** #9273 ## Summary - support tap/touch events for tooltip - cleanup - removed private vars for hoveredTooltip, clickedTooltip to simplify things - add test

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.30.0</summary> ## [3.30.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons-v3.29.0...@esri/calcite-ui-icons@3.30.0) (2024-07-31) ### Miscellaneous Chores * Add calcite-ui-icons to monorepo ([#9835](#9835)) ([05264ea](05264ea)) </details> <details><summary>@esri/calcite-components: 2.11.0</summary> ## [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.10.1...@esri/calcite-components@2.11.0) (2024-07-31) ### Features * **chip:** Enhance multi-select group affordance ([#9286](#9286)) ([fd150e1](fd150e1)) * **color-picker, color-picker-hex-input:** Add input auto commit, blur and auto select enhancements. ([#9701](#9701)) ([b2be625](b2be625)) * **combobox-item:** Apply heading color according to updated spec ([#9883](#9883)) ([9f642ff](9f642ff)) * **combobox, combobox-item:** Add `description`, `shortHeading` props and `content-end` slot ([#9771](#9771)) ([78eb555](78eb555)) * **combobox, combobox-item:** Add `metadata` support for filtering ([#9819](#9819)) ([5de7787](5de7787)) * **combobox:** Append custom values to top of dropdown ([#9817](#9817)) ([bd55097](bd55097)) * **dialog:** Add padding to default slot ([#9871](#9871)) ([9d89d1d](9d89d1d)) * **dialog:** Adds new dialog component and deprecates the modal component ([#9751](#9751)) ([0111c23](0111c23)) * **icon:** Type icon names ([#9650](#9650)) ([7513f3a](7513f3a)) * **panel, flow-item:** Add alerts slot ([#9778](#9778)) ([8b9b820](8b9b820)) * **panel, flow-item:** Add beforeClose property ([#9770](#9770)) ([aefd3cb](aefd3cb)) * **panel, flow-item:** Add scale property ([#9730](#9730)) ([27c597e](27c597e)) * Provide info message on stamped version instead of warning ([#9739](#9739)) ([b25cb7b](b25cb7b)) * **shell-panel:** Deprecate float displayMode and add float-content and float-all ([#9795](#9795)) ([bf93728](bf93728)) * **tooltip:** Support touch events ([#9487](#9487)) ([633706b](633706b)) ### Bug Fixes * **block-section:** Apply missing CSS class to start/end icon ([#9688](#9688)) ([2169ed2](2169ed2)) * **block:** Remove top padding when no heading is defined ([#9782](#9782)) ([704f5df](704f5df)) * **carousel:** Prevent duplicate animation when navigating via keyboard ([#9848](#9848)) ([cfdbd44](cfdbd44)) * **combobox-item:** Tweak center content font-weight and spacing ([#9818](#9818)) ([a67c4af](a67c4af)) * **deps:** Move @types/sortablejs as a dependency so the public types resolve properly ([#9786](#9786)) ([3d47c52](3d47c52)) * **dialog:** Fix menu positioning when when overlayPositioning is 'fixed' and menuOpen is true ([#9891](#9891)) ([4390177](4390177)) * Fix issue in Firefox where disabled elements were incorrectly enabled when a sibling was enabled ([#9710](#9710)) ([cd4d52c](cd4d52c)) * **flow-item:** Set closed property to true when internal panel is closed ([#9715](#9715)) ([f7d2a4f](f7d2a4f)) * Improve browser check to resolve SSR errors ([#9897](#9897)) ([bdb225b](bdb225b)) * **input-date-picker:** Ensure initial value is in range ([#9894](#9894)) ([7d05134](7d05134)) * **input-number:** Restore decimal input mode default ([#9741](#9741)) ([1165dca](1165dca)) * **panel, flow-item:** Fix footer-padding CSS prop regression ([#9757](#9757)) ([f935790](f935790)) * **panel, flow-item:** Prevent footer slots from conflicting with each other ([#9856](#9856)) ([cffaff8](cffaff8)) * **panel:** Correct footer padding and layout ([#9868](#9868)) ([1e02ece](1e02ece)) * **radio-button-group:** Remove blank clickable space outside of label ([#9793](#9793)) ([4cc24a0](4cc24a0)) * **segmented-control:** Make check state update correctly ([#9733](#9733)) ([602c922](602c922)) * **shell:** Fix resizing a slotted shell-panel when clicking to resize ([#9846](#9846)) ([326001c](326001c)) * **shell:** Update shell to correctly position calcite shell panel at shell's bottom ([#9748](#9748)) ([5959db7](5959db7)) * **tab-title:** Adjust hover styling for `bordered` Tab Title ([#9867](#9867)) ([a77cd27](a77cd27)) * **tabs:** Handle tab close events that remove the associated tab-title and tab elements from the DOM ([#9768](#9768)) ([bda619c](bda619c)) * **tabs:** Update tab title indicator display ([#9666](#9666)) ([5f0914b](5f0914b)) * **tile:** Center align contentTop and contentBottom slots when alignment prop equals "center" ([#9732](#9732)) ([1a8393b](1a8393b)) * **tile:** Center align slot's text when alignment is equal to center ([#9773](#9773)) ([8611bfc](8611bfc)) * **time-picker:** Render meridiem first for korean locale ([#9842](#9842)) ([897f924](897f924)) * **tooltip:** Allow focusing on a reference element and then clicking on a tooltip ([#9878](#9878)) ([dfca2d4](dfca2d4)) * Widen icon type to allow string ([#9915](#9915)) ([44138b1](44138b1)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from ^3.29.1-next.0 to ^3.30.0 </details> <details><summary>@esri/calcite-components-angular: 2.11.0</summary> ## [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.1...@esri/calcite-components-angular@2.11.0) (2024-07-31) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> <details><summary>@esri/calcite-components-react: 2.11.0</summary> ## [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.1...@esri/calcite-components-react@2.11.0) (2024-07-31) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.30.0</summary> [3.30.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons-v3.29.0...@esri/calcite-ui-icons@3.30.0) (2024-07-31) * Add calcite-ui-icons to monorepo ([#9835](#9835)) ([05264ea](05264ea)) </details> <details><summary>@esri/calcite-components: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.10.1...@esri/calcite-components@2.11.0) (2024-07-31) * **chip:** Enhance multi-select group affordance ([#9286](#9286)) ([fd150e1](fd150e1)) * **color-picker, color-picker-hex-input:** Add input auto commit, blur and auto select enhancements. ([#9701](#9701)) ([b2be625](b2be625)) * **combobox-item:** Apply heading color according to updated spec ([#9883](#9883)) ([9f642ff](9f642ff)) * **combobox, combobox-item:** Add `description`, `shortHeading` props and `content-end` slot ([#9771](#9771)) ([78eb555](78eb555)) * **combobox, combobox-item:** Add `metadata` support for filtering ([#9819](#9819)) ([5de7787](5de7787)) * **combobox:** Append custom values to top of dropdown ([#9817](#9817)) ([bd55097](bd55097)) * **dialog:** Add padding to default slot ([#9871](#9871)) ([9d89d1d](9d89d1d)) * **dialog:** Adds new dialog component and deprecates the modal component ([#9751](#9751)) ([0111c23](0111c23)) * **icon:** Type icon names ([#9650](#9650)) ([7513f3a](7513f3a)) * **panel, flow-item:** Add alerts slot ([#9778](#9778)) ([8b9b820](8b9b820)) * **panel, flow-item:** Add beforeClose property ([#9770](#9770)) ([aefd3cb](aefd3cb)) * **panel, flow-item:** Add scale property ([#9730](#9730)) ([27c597e](27c597e)) * Provide info message on stamped version instead of warning ([#9739](#9739)) ([b25cb7b](b25cb7b)) * **shell-panel:** Deprecate float displayMode and add float-content and float-all ([#9795](#9795)) ([bf93728](bf93728)) * **tooltip:** Support touch events ([#9487](#9487)) ([633706b](633706b)) * **block-section:** Apply missing CSS class to start/end icon ([#9688](#9688)) ([2169ed2](2169ed2)) * **block:** Remove top padding when no heading is defined ([#9782](#9782)) ([704f5df](704f5df)) * **carousel:** Prevent duplicate animation when navigating via keyboard ([#9848](#9848)) ([cfdbd44](cfdbd44)) * **combobox-item:** Tweak center content font-weight and spacing ([#9818](#9818)) ([a67c4af](a67c4af)) * **deps:** Move @types/sortablejs as a dependency so the public types resolve properly ([#9786](#9786)) ([3d47c52](3d47c52)) * **dialog:** Fix menu positioning when when overlayPositioning is 'fixed' and menuOpen is true ([#9891](#9891)) ([4390177](4390177)) * Fix issue in Firefox where disabled elements were incorrectly enabled when a sibling was enabled ([#9710](#9710)) ([cd4d52c](cd4d52c)) * **flow-item:** Set closed property to true when internal panel is closed ([#9715](#9715)) ([f7d2a4f](f7d2a4f)) * Improve browser check to resolve SSR errors ([#9897](#9897)) ([bdb225b](bdb225b)) * **input-date-picker:** Ensure initial value is in range ([#9894](#9894)) ([7d05134](7d05134)) * **input-number:** Restore decimal input mode default ([#9741](#9741)) ([1165dca](1165dca)) * **panel, flow-item:** Fix footer-padding CSS prop regression ([#9757](#9757)) ([f935790](f935790)) * **panel, flow-item:** Prevent footer slots from conflicting with each other ([#9856](#9856)) ([cffaff8](cffaff8)) * **panel:** Correct footer padding and layout ([#9868](#9868)) ([1e02ece](1e02ece)) * **radio-button-group:** Remove blank clickable space outside of label ([#9793](#9793)) ([4cc24a0](4cc24a0)) * **segmented-control:** Make check state update correctly ([#9733](#9733)) ([602c922](602c922)) * **shell:** Fix resizing a slotted shell-panel when clicking to resize ([#9846](#9846)) ([326001c](326001c)) * **shell:** Update shell to correctly position calcite shell panel at shell's bottom ([#9748](#9748)) ([5959db7](5959db7)) * **tab-title:** Adjust hover styling for `bordered` Tab Title ([#9867](#9867)) ([a77cd27](a77cd27)) * **tabs:** Handle tab close events that remove the associated tab-title and tab elements from the DOM ([#9768](#9768)) ([bda619c](bda619c)) * **tabs:** Update tab title indicator display ([#9666](#9666)) ([5f0914b](5f0914b)) * **tile:** Center align contentTop and contentBottom slots when alignment prop equals "center" ([#9732](#9732)) ([1a8393b](1a8393b)) * **tile:** Center align slot's text when alignment is equal to center ([#9773](#9773)) ([8611bfc](8611bfc)) * **time-picker:** Render meridiem first for korean locale ([#9842](#9842)) ([897f924](897f924)) * **tooltip:** Allow focusing on a reference element and then clicking on a tooltip ([#9878](#9878)) ([dfca2d4](dfca2d4)) * Widen icon type to allow string ([#9915](#9915)) ([44138b1](44138b1)) * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from ^3.29.1-next.0 to ^3.30.0 </details> <details><summary>@esri/calcite-components-angular: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.1...@esri/calcite-components-angular@2.11.0) (2024-07-31) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> <details><summary>@esri/calcite-components-react: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.1...@esri/calcite-components-react@2.11.0) (2024-07-31) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Cherry-pick the release commit from `main`. --- <details><summary>@esri/calcite-ui-icons: 3.30.0</summary> [3.30.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons-v3.29.0...@esri/calcite-ui-icons@3.30.0) (2024-07-31) * Add calcite-ui-icons to monorepo ([#9835](#9835)) ([05264ea](05264ea)) </details> <details><summary>@esri/calcite-components: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.10.1...@esri/calcite-components@2.11.0) (2024-07-31) * **chip:** Enhance multi-select group affordance ([#9286](#9286)) ([fd150e1](fd150e1)) * **color-picker, color-picker-hex-input:** Add input auto commit, blur and auto select enhancements. ([#9701](#9701)) ([b2be625](b2be625)) * **combobox-item:** Apply heading color according to updated spec ([#9883](#9883)) ([9f642ff](9f642ff)) * **combobox, combobox-item:** Add `description`, `shortHeading` props and `content-end` slot ([#9771](#9771)) ([78eb555](78eb555)) * **combobox, combobox-item:** Add `metadata` support for filtering ([#9819](#9819)) ([5de7787](5de7787)) * **combobox:** Append custom values to top of dropdown ([#9817](#9817)) ([bd55097](bd55097)) * **dialog:** Add padding to default slot ([#9871](#9871)) ([9d89d1d](9d89d1d)) * **dialog:** Adds new dialog component and deprecates the modal component ([#9751](#9751)) ([0111c23](0111c23)) * **icon:** Type icon names ([#9650](#9650)) ([7513f3a](7513f3a)) * **panel, flow-item:** Add alerts slot ([#9778](#9778)) ([8b9b820](8b9b820)) * **panel, flow-item:** Add beforeClose property ([#9770](#9770)) ([aefd3cb](aefd3cb)) * **panel, flow-item:** Add scale property ([#9730](#9730)) ([27c597e](27c597e)) * Provide info message on stamped version instead of warning ([#9739](#9739)) ([b25cb7b](b25cb7b)) * **shell-panel:** Deprecate float displayMode and add float-content and float-all ([#9795](#9795)) ([bf93728](bf93728)) * **tooltip:** Support touch events ([#9487](#9487)) ([633706b](633706b)) * **block-section:** Apply missing CSS class to start/end icon ([#9688](#9688)) ([2169ed2](2169ed2)) * **block:** Remove top padding when no heading is defined ([#9782](#9782)) ([704f5df](704f5df)) * **carousel:** Prevent duplicate animation when navigating via keyboard ([#9848](#9848)) ([cfdbd44](cfdbd44)) * **combobox-item:** Tweak center content font-weight and spacing ([#9818](#9818)) ([a67c4af](a67c4af)) * **deps:** Move @types/sortablejs as a dependency so the public types resolve properly ([#9786](#9786)) ([3d47c52](3d47c52)) * **dialog:** Fix menu positioning when when overlayPositioning is 'fixed' and menuOpen is true ([#9891](#9891)) ([4390177](4390177)) * Fix issue in Firefox where disabled elements were incorrectly enabled when a sibling was enabled ([#9710](#9710)) ([cd4d52c](cd4d52c)) * **flow-item:** Set closed property to true when internal panel is closed ([#9715](#9715)) ([f7d2a4f](f7d2a4f)) * Improve browser check to resolve SSR errors ([#9897](#9897)) ([bdb225b](bdb225b)) * **input-date-picker:** Ensure initial value is in range ([#9894](#9894)) ([7d05134](7d05134)) * **input-number:** Restore decimal input mode default ([#9741](#9741)) ([1165dca](1165dca)) * **panel, flow-item:** Fix footer-padding CSS prop regression ([#9757](#9757)) ([f935790](f935790)) * **panel, flow-item:** Prevent footer slots from conflicting with each other ([#9856](#9856)) ([cffaff8](cffaff8)) * **panel:** Correct footer padding and layout ([#9868](#9868)) ([1e02ece](1e02ece)) * **radio-button-group:** Remove blank clickable space outside of label ([#9793](#9793)) ([4cc24a0](4cc24a0)) * **segmented-control:** Make check state update correctly ([#9733](#9733)) ([602c922](602c922)) * **shell:** Fix resizing a slotted shell-panel when clicking to resize ([#9846](#9846)) ([326001c](326001c)) * **shell:** Update shell to correctly position calcite shell panel at shell's bottom ([#9748](#9748)) ([5959db7](5959db7)) * **tab-title:** Adjust hover styling for `bordered` Tab Title ([#9867](#9867)) ([a77cd27](a77cd27)) * **tabs:** Handle tab close events that remove the associated tab-title and tab elements from the DOM ([#9768](#9768)) ([bda619c](bda619c)) * **tabs:** Update tab title indicator display ([#9666](#9666)) ([5f0914b](5f0914b)) * **tile:** Center align contentTop and contentBottom slots when alignment prop equals "center" ([#9732](#9732)) ([1a8393b](1a8393b)) * **tile:** Center align slot's text when alignment is equal to center ([#9773](#9773)) ([8611bfc](8611bfc)) * **time-picker:** Render meridiem first for korean locale ([#9842](#9842)) ([897f924](897f924)) * **tooltip:** Allow focusing on a reference element and then clicking on a tooltip ([#9878](#9878)) ([dfca2d4](dfca2d4)) * Widen icon type to allow string ([#9915](#9915)) ([44138b1](44138b1)) * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from ^3.29.1-next.0 to ^3.30.0 </details> <details><summary>@esri/calcite-components-angular: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.1...@esri/calcite-components-angular@2.11.0) (2024-07-31) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> <details><summary>@esri/calcite-components-react: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.1...@esri/calcite-components-react@2.11.0) (2024-07-31) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> **Related Issue:** # ## Summary Co-authored-by: Calcite Admin <calcite-admin@esri.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat(tooltip): support touch events. #9273

a68df43

github-actions bot assigned driskull May 31, 2024

github-actions bot added the enhancement Issues tied to a new feature or request. label May 31, 2024

driskull marked this pull request as ready for review May 31, 2024 23:03

driskull requested a review from a team as a code owner May 31, 2024 23:03

github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 8, 2024

benelan changed the base branch from main to dev June 10, 2024 09:10

github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 11, 2024

driskull requested a review from jcfranco June 17, 2024 18:47

jcfranco requested changes Jun 21, 2024

View reviewed changes

driskull added 2 commits June 21, 2024 15:24

review fixes

469e64d

remove outdated test

6cd6f7d

driskull requested a review from jcfranco June 21, 2024 22:25

driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 22, 2024

github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jul 2, 2024

driskull changed the title ~~feat(tooltip): support touch events~~ feat(tooltip): support touch events [WIP] Jul 18, 2024

github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jul 19, 2024

driskull added 3 commits July 19, 2024 14:47

WIP

8badb1b

WIP

760c3e9

cleanup

ae69a00

driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 19, 2024

driskull changed the title ~~feat(tooltip): support touch events [WIP]~~ feat(tooltip): support touch events Jul 19, 2024

jcfranco approved these changes Jul 22, 2024

View reviewed changes

fix tests

2507dbd

driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 22, 2024

driskull merged commit 77459fb into dev Jul 22, 2024
12 checks passed

driskull deleted the dris0000/tooltip-touch-events branch July 22, 2024 17:39

github-actions bot added this to the 2024-07-30 - Jul Release milestone Jul 22, 2024

calcite-admin mentioned this pull request Jul 30, 2024

chore: release main #9716

Merged

benelan mentioned this pull request Jul 31, 2024

chore: release main (#9716) #9916

Merged

benelan mentioned this pull request Aug 28, 2024

chore: release main #10171

Merged

geospatialem mentioned this pull request Sep 27, 2024

[Tooltip] Will reappear and block actions within a menu #10416

Closed

6 tasks

calcite-admin mentioned this pull request Sep 30, 2024

chore: release main #10457

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tooltip): support touch events #9487

feat(tooltip): support touch events #9487

driskull commented May 31, 2024 •

edited

Loading

github-actions bot commented Jun 8, 2024

driskull commented Jun 20, 2024

jcfranco Jun 21, 2024

driskull Jun 21, 2024

driskull commented Jun 22, 2024

jcfranco commented Jun 22, 2024 •

edited

Loading

driskull commented Jun 22, 2024

jcfranco commented Jun 22, 2024

github-actions bot commented Jul 2, 2024

driskull commented Jul 19, 2024

driskull commented Jul 19, 2024

jcfranco left a comment

jcfranco Jul 22, 2024

jcfranco Jul 22, 2024

driskull Jul 22, 2024

jcfranco commented Jul 22, 2024

driskull commented Jul 22, 2024

feat(tooltip): support touch events #9487

feat(tooltip): support touch events #9487

Conversation

driskull commented May 31, 2024 • edited Loading

Summary

github-actions bot commented Jun 8, 2024

driskull commented Jun 20, 2024

jcfranco Jun 21, 2024

Choose a reason for hiding this comment

driskull Jun 21, 2024

Choose a reason for hiding this comment

driskull commented Jun 22, 2024

jcfranco commented Jun 22, 2024 • edited Loading

driskull commented Jun 22, 2024

jcfranco commented Jun 22, 2024

github-actions bot commented Jul 2, 2024

driskull commented Jul 19, 2024

driskull commented Jul 19, 2024

jcfranco left a comment

Choose a reason for hiding this comment

jcfranco Jul 22, 2024

Choose a reason for hiding this comment

jcfranco Jul 22, 2024

Choose a reason for hiding this comment

driskull Jul 22, 2024

Choose a reason for hiding this comment

jcfranco commented Jul 22, 2024

driskull commented Jul 22, 2024

driskull commented May 31, 2024 •

edited

Loading

jcfranco commented Jun 22, 2024 •

edited

Loading