Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): add resizable and dragEnabled properties #9804

Merged
merged 127 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from 119 commits
Commits
Show all changes
127 commits
Select commit Hold shift + click to select a range
57dd466
dialog WIP
driskull Jul 8, 2024
595df41
WIP
driskull Jul 8, 2024
587952d
WIP
driskull Jul 9, 2024
204b1a4
WIP
driskull Jul 9, 2024
8662fa9
Merge branch 'dev' into dris0000/dialog
driskull Jul 9, 2024
224cdd3
scale
driskull Jul 9, 2024
150b792
wip
driskull Jul 9, 2024
ef470f4
WIP
driskull Jul 9, 2024
59e1891
WIP
driskull Jul 9, 2024
5408e5c
WIP
driskull Jul 9, 2024
5047695
WIP
driskull Jul 9, 2024
0cf10dc
WIP
driskull Jul 9, 2024
c4c7044
WIP
driskull Jul 9, 2024
f0b1c0a
WIP
driskull Jul 9, 2024
209e072
cleanup
driskull Jul 9, 2024
2b8c4af
WIP
driskull Jul 9, 2024
bc17fe2
WIP
driskull Jul 9, 2024
9840498
WIP
driskull Jul 9, 2024
56e0efa
feat(dialog): adds new dialog component and deprecates the modal comp…
driskull Jul 9, 2024
1a3cfe3
cleanup
driskull Jul 10, 2024
5b4ab5a
WIP
driskull Jul 10, 2024
3d08942
cleanup
driskull Jul 11, 2024
c7e237c
cleanup
driskull Jul 11, 2024
af40f98
fix tests
driskull Jul 11, 2024
624337e
no disabled prop, fix tests
driskull Jul 11, 2024
f6d0f5f
cleanup
driskull Jul 11, 2024
3b8ddc8
WIP
driskull Jul 11, 2024
5a03a15
modal swapping
driskull Jul 11, 2024
fdb891e
tests
driskull Jul 11, 2024
c5b52df
cleanup
driskull Jul 11, 2024
48467f4
remove code
driskull Jul 11, 2024
9638516
cleanup
driskull Jul 11, 2024
e4c5c1e
theming
driskull Jul 11, 2024
323da6f
cleanup
driskull Jul 11, 2024
3f0f2ed
Merge branch 'dev' into dris0000/dialog
driskull Jul 11, 2024
1856d46
placement option
driskull Jul 12, 2024
ed970a9
WIP
driskull Jul 12, 2024
70c711c
cleanup
driskull Jul 12, 2024
a68f55a
cleanup
driskull Jul 12, 2024
f0e81f2
WIP
driskull Jul 12, 2024
2f152b9
WIP
driskull Jul 12, 2024
55342ea
cleanup
driskull Jul 13, 2024
b63b8c7
WIP
driskull Jul 15, 2024
defc018
cleanup
driskull Jul 15, 2024
7c5a5d0
demos
driskull Jul 15, 2024
31cf83e
Merge branch 'dev' into dris0000/dialog
driskull Jul 15, 2024
c86f35c
fix tests
driskull Jul 15, 2024
c898a7e
add test for calcitePanelClose
driskull Jul 15, 2024
863075d
cleanup
driskull Jul 15, 2024
d33bfdb
cleanup
driskull Jul 15, 2024
9e56b4c
get demo page working in shadow dom.
driskull Jul 15, 2024
ee05c98
fix alert slots and test
driskull Jul 15, 2024
9ff443d
Merge branch 'dev' into dris0000/dialog
driskull Jul 16, 2024
f78e9e5
update stories
driskull Jul 16, 2024
2bd6ff7
WIP prototype
driskull Jul 16, 2024
5635633
cleanup css
driskull Jul 16, 2024
2e73172
Merge branch 'dev' into dris0000/dialog
driskull Jul 16, 2024
b15f12f
Merge branch 'dris0000/dialog' into dris0000/dialog-resizable
driskull Jul 16, 2024
ed337ca
WIP
driskull Jul 16, 2024
82bc771
WIP
driskull Jul 16, 2024
ab1fcb4
cleanup
driskull Jul 17, 2024
6fe84b1
constrain keyboard
driskull Jul 17, 2024
112a303
cleanup
driskull Jul 17, 2024
a8dc15a
cleanup
driskull Jul 17, 2024
dbf56a1
tokens review fixes
driskull Jul 17, 2024
7a54014
Merge branch 'dris0000/dialog' into dris0000/dialog-resizable
driskull Jul 17, 2024
a75527d
html
driskull Jul 17, 2024
23b94df
Test WIP
driskull Jul 18, 2024
d2e6bcb
keyboard resize tests
driskull Jul 18, 2024
93569b9
aria-live WIP
driskull Jul 18, 2024
ec1c126
moar tests
driskull Jul 18, 2024
4fb101e
review fixes
driskull Jul 19, 2024
3e7c455
update typings
driskull Jul 19, 2024
b2073a0
review fixes
driskull Jul 23, 2024
8dbd5af
fix story attribute
driskull Jul 23, 2024
707a56e
Merge branch 'dris0000/dialog' into dris0000/dialog-resizable
driskull Jul 23, 2024
58313d5
cleanup
driskull Jul 23, 2024
86f161f
Merge branch 'dev' into dris0000/dialog-resizable
driskull Jul 26, 2024
33a9f61
cleanup
driskull Jul 26, 2024
49b710a
Merge branch 'dev' into dris0000/dialog-resizable
driskull Jul 30, 2024
0b5cf5d
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 2, 2024
0ce2d44
cleanup
driskull Aug 2, 2024
8359ec9
fix animation and drag speed, add min height/width values.
driskull Aug 5, 2024
99271b7
fix test
driskull Aug 5, 2024
c869106
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 5, 2024
e6cccf3
cleanup css
driskull Aug 5, 2024
d7d621d
cleanup
driskull Aug 6, 2024
66f1a68
remove some css
driskull Aug 13, 2024
bae084b
cleanup min sizes
driskull Aug 13, 2024
79f6108
set min heights and widths for scales. add css var for overriding. ad…
driskull Aug 13, 2024
ed8da75
cleanup
driskull Aug 13, 2024
8066cb4
cleanup
driskull Aug 14, 2024
b1d84e6
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 14, 2024
a705671
refactor css
driskull Aug 14, 2024
21ac612
test
driskull Aug 14, 2024
842ea8d
revert margin change.
driskull Aug 14, 2024
a8fab23
partial review fixes
driskull Aug 14, 2024
e6ae23e
fix animations
driskull Aug 14, 2024
527a20a
handle dialog resizable and dragEnabled change after initialization
driskull Aug 14, 2024
5248b06
cleanup
driskull Aug 14, 2024
decf0d0
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 15, 2024
8c2f064
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 16, 2024
cc6f6a6
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 19, 2024
4794846
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 19, 2024
16567c3
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 22, 2024
b7eea59
fix e2e
driskull Aug 22, 2024
467fd47
cleanup
driskull Aug 22, 2024
5545d39
WIP
driskull Aug 23, 2024
fbf7eb5
WIP
driskull Aug 23, 2024
2386c42
WIP
driskull Aug 23, 2024
e34e84a
WIP
driskull Aug 24, 2024
a7a0067
WIP
driskull Aug 24, 2024
7095d05
cleanup
driskull Aug 24, 2024
c09569d
cleanup
driskull Aug 26, 2024
45efac7
cleanup
driskull Aug 26, 2024
7e966a6
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 26, 2024
d8755e8
cleanup
driskull Aug 26, 2024
9ea8042
cleanup
driskull Aug 26, 2024
68c5588
cleanup
driskull Aug 26, 2024
c3deaf7
update sizes
driskull Aug 27, 2024
a341351
review fixes
driskull Aug 27, 2024
5af511c
update test
driskull Aug 27, 2024
8fd4fd2
add css vars
driskull Aug 27, 2024
6817a26
cleanup
driskull Aug 27, 2024
b9d5187
Merge branch 'dev' into dris0000/dialog-resizable
driskull Aug 27, 2024
c9308e0
cleanup
driskull Aug 27, 2024
84fd0bb
fix resize keyboard direction for up/down arrows
driskull Aug 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/calcite-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"composed-offset-position": "0.0.6",
"dayjs": "1.11.12",
"focus-trap": "7.5.4",
"interactjs": "1.10.27",
"lodash-es": "4.17.21",
"sortablejs": "1.15.1",
"timezone-groups": "0.9.1",
Expand Down
16 changes: 16 additions & 0 deletions packages/calcite-components/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1696,6 +1696,10 @@ export namespace Components {
* A description for the component.
*/
"description": string;
/**
* When `true`, the component is draggable.
*/
"dragEnabled": boolean;
/**
* This internal property, managed by a containing calcite-shell, is used to inform the component if special configuration or styles are needed
*/
Expand Down Expand Up @@ -1753,6 +1757,10 @@ export namespace Components {
* Specifies the placement of the dialog.
*/
"placement": DialogPlacement;
/**
* When `true`, the component is resizable.
*/
"resizable": boolean;
/**
* Specifies the size of the component.
*/
Expand Down Expand Up @@ -9703,6 +9711,10 @@ declare namespace LocalJSX {
* A description for the component.
*/
"description"?: string;
/**
* When `true`, the component is draggable.
*/
"dragEnabled"?: boolean;
/**
* This internal property, managed by a containing calcite-shell, is used to inform the component if special configuration or styles are needed
*/
Expand Down Expand Up @@ -9780,6 +9792,10 @@ declare namespace LocalJSX {
* Specifies the placement of the dialog.
*/
"placement"?: DialogPlacement;
/**
* When `true`, the component is resizable.
*/
"resizable"?: boolean;
/**
* Specifies the size of the component.
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{
"close": "Close"
"close": "Close",
"resizeEnabled": "Resize enabled. Use the shift and arrow keys to resize the dialog.",
"dragEnabled": "Drag enabled. Use the arrow keys to move the dialog."
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{
"close": "Close"
"close": "Close",
"resizeEnabled": "Resize enabled. Use the shift and arrow keys to resize the dialog.",
"dragEnabled": "Drag enabled. Use the arrow keys to move the dialog."
}
Loading
Loading