From 8bc01aa9df7483e0f173e6964623ddc5dfa4bd56 Mon Sep 17 00:00:00 2001 From: Nikolas Wise Date: Wed, 10 Aug 2016 09:07:57 -0700 Subject: [PATCH 1/4] make dropdown filter anchor not invisible to the dom --- lib/sass/calcite-web/patterns/_filter-dropdown.scss | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/sass/calcite-web/patterns/_filter-dropdown.scss b/lib/sass/calcite-web/patterns/_filter-dropdown.scss index 8ef53fd92..fce3325d5 100644 --- a/lib/sass/calcite-web/patterns/_filter-dropdown.scss +++ b/lib/sass/calcite-web/patterns/_filter-dropdown.scss @@ -125,7 +125,7 @@ @include box-sizing(border-box); position: relative; display: inline-block; - padding: $baseline/3 $baseline $baseline/3 $baseline/3; + padding: $baseline/3 0 $baseline/3 $baseline/3; margin-right: $baseline/6; margin-top: $baseline/6; color: $darker-gray; @@ -140,8 +140,7 @@ @include font-size(-1); @extend %icon-font-styles; @extend .icon-ui-close:before; - position: absolute; - right: 0; + margin-left: $baseline/3; @if ($include-right-to-left) { html[dir="rtl"] & { right: auto; From 2f299c6503b2b10312abdfc533a4fd09a4046072 Mon Sep 17 00:00:00 2001 From: Nikolas Wise Date: Wed, 10 Aug 2016 09:08:57 -0700 Subject: [PATCH 2/4] changelog that --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cbbdd17c3..feb65d736 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +## Unreleased + +### Fixed +- `filter-dropdown-remove:after` no longer positioned absolutely + ## 1.0.0-beta.30 ### Removed From 2d838dd65c6508ad8976ded3a4af0a2cdffb3886 Mon Sep 17 00:00:00 2001 From: Nikolas Wise Date: Thu, 11 Aug 2016 09:33:00 -0700 Subject: [PATCH 3/4] wcag contrast on clear buttons for non white settings --- CHANGELOG.md | 3 +++ lib/sass/calcite-web/components/_button.scss | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index feb65d736..c59d98a03 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,9 @@ ### Fixed - `filter-dropdown-remove:after` no longer positioned absolutely +### Modified +- `btn-clear` has bg white, rathe than transparent for ACAG on light grays. + ## 1.0.0-beta.30 ### Removed diff --git a/lib/sass/calcite-web/components/_button.scss b/lib/sass/calcite-web/components/_button.scss index d1fd46ddc..b3d8dec66 100644 --- a/lib/sass/calcite-web/components/_button.scss +++ b/lib/sass/calcite-web/components/_button.scss @@ -43,7 +43,7 @@ @mixin btn-clear() { color: $blue; - background: transparent; + background: $white; border-color: $blue; &:hover { color: $white; From d7427e821fa6343cc5cf505daf62423f9783bf7b Mon Sep 17 00:00:00 2001 From: Nikolas Wise Date: Thu, 11 Aug 2016 09:48:59 -0700 Subject: [PATCH 4/4] temp remove doc for modifiers on inputs --- docs/source/table_of_contents.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/docs/source/table_of_contents.yml b/docs/source/table_of_contents.yml index d32d43ae7..b816396df 100644 --- a/docs/source/table_of_contents.yml +++ b/docs/source/table_of_contents.yml @@ -372,19 +372,13 @@ components: modifiers: true - title: 'Text Inputs' link: text-inputs - modifiers: - - 'input-error' - - 'input-warning' - - 'input-success' + modifiers: true - title: 'Input Groups' link: input-groups modifiers: true - title: 'Selects' link: selects - modifiers: - - input-error - - input-warning - - input-success + modifiers: true - title: 'Checkboxes' link: checkboxes modifiers: true