trim height of export requests when necessary #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var bottom = this._map.latLngToLayerPoint(bounds._southWest); | ||
|
|
||
| if (top.y > 0 || bottom.y < total.y){ | ||
| size.y = total.y - top.y - (total.y - bottom.y); |
There was a problem hiding this comment.
Maybe reduce this to size.y = bottom.y - top.y? By using size instead of total in the if condition, you can get rid of total completely.
There was a problem hiding this comment.
i'm still using total in the check above, but 👍 for simpler maths!
| var top = this._map.latLngToLayerPoint(bounds._northEast); | ||
| var bottom = this._map.latLngToLayerPoint(bounds._southWest); | ||
|
|
||
| if (top.y > 0 || bottom.y < size.y){ |
There was a problem hiding this comment.
looking at this again, i guess we could even skip the check entirely.
if the map fills up the whole div, bottom.y - top.y still returns the height we want.
There was a problem hiding this comment.
Lets leave the check in there just for safety.
|
Looks good! |
patrickarlt
added a commit
that referenced
this pull request
Mar 18, 2015
trim height of export requests when necessary
jgravois
added a commit
that referenced
this pull request
Apr 21, 2016
jgravois
added a commit
that referenced
this pull request
Apr 26, 2016
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
trim height of export requests when necessary
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #450
i was able to correct the distortion seen in DynamicMapLayer overlays in scenarios where whitespace surrounds the map by introducing a quick check into
_buildExportParamsto compare the height of the div to the top and bottom y values of the actual map (in screen coordinates) and trimming if appropriate.confirmed that display behavior is improved for web mercator basemaps, even when L.tileLayer noWrap is set to true
confirmed that display behavior is appropriate in leaflet-1.0 branch as well (with the exception of the fact that the area below 85deg south isn't cropped appropriately)
happy to include relevant tests prior to merge, just wanted to make sure everyone's happy with the methodology first.
cc @nixta